From: Benny M. <ben...@gm...> - 2009-07-17 10:42:53
|
Hi, about the event tab changes committed last night, http://blog.gramps-project.org/?p=135 There are probably still issues in the following use case: 1/open a person and select an event to share, see the the eventref editor pop up 2/in the eventview move to an event 3/update the event, and save. The callback will update the event view but also the event tab with the new code. This fits in light of the old and well known bug http://www.gramps-project.org/bugs/view.php?id=1277 I'll work on it on holiday, but am thinking that to solve all possible issues that can arise like that, we might perhaps better create a more fine grained callback system. That is, connect to eg the database signal update-event, but only if the eventhandle passed is in the changed list. That would move away parsing if one of the handles one works with are changed away from the callback function, into the caller of the callback. It would simplify things like the following: Open up the person editor, connect all primary events involved to a change of them specifically (so the families, the sources, the events, notes, ....). Then the person editor only recieves a callback signal if something that is really shown or stored in the editor changes. Something to think about. Benny |