From: Benny M. <ben...@gm...> - 2009-05-20 09:33:53
|
2009/5/20 Gerald Britton <ger...@gm...> > I saw that a while ago. The frustrating thing is that no one is taking > responsibility for fixing it properly afaics. I'll start running my > test system with new style classes to see if it breaks anything. > Gerald, I would suggest to commit the changes to gramps31 and trunk, so more people run it. Can you do that? Perhaps also keep a patch list on the bug (or the involved rev numbers) for should we need it for gramps30/gramps22 branch later too (just too keep them working in subversion). I would think that if Managedwindow is a new style class, then all classes that inherit from ManagedWindow and from some other class, should have for the other class also new style object. Apparently this is not needed, but looks strange to me. Benny > > > > On 5/19/09, Benny Malengier <ben...@gm...> wrote: > > It looks like Josip might have found a fix for the recent GRAMPS crash > > plague. > > > > Possible clue and solution is in > > http://bugzilla.gnome.org/show_bug.cgi?id=578419 > > done in GRAMPS in http://www.gramps-project.org/bugs/view.php?id=3008 > > > > If everybody that has seen this crash can try on their boxes. I > personally > > have not had the crash yet. > > So the change is > > > > --- src/ManagedWindow.py (revision 12549) > > +++ src/ManagedWindow.py (working copy) > > @@ -285,7 +285,7 @@ > > # Gramps Managed Window class > > # > > > #------------------------------------------------------------------------- > > -class ManagedWindow: > > +class ManagedWindow(object): > > """ > > Managed window base class. > > > > If it fixes things, we need to investigate the consequence of using new > > style objects in the 3.1.x branch. This was only planned for 3.2, but > > clearly old style objects are not working as good anymore in gtk/python > as > > they used to. > > > > Benny > > > > -- > Sent from my mobile device > > Gerald Britton > |