From: Gerald B. <ger...@gm...> - 2009-03-26 15:37:58
|
I believe the argument is valid, because one goal for the write() method to stay out of the way as much as possible -- that is not to inspect the data for special processing but just to regurgitate it faithfully. Also, if your file looks like this: <html><head><title>Title</title></head><body>Body</body></html> If you do View Source in Firefox, e.g. you see just that (and you should). Putting explict indents in makes it more readable with this parameter. Of course the indent parameter is optional, and if you use a different tool to view the source then it can be left out entirely and the whole discussion is moot. I take your point about making indent=True the default, however. I believe that it is probably the more common case. It shouldn't cause much problem to retrofit in WebCal either, since it is used in most calls. (We only have to find where it is *not* used and add indent=False. Should be trivial.) On Thu, Mar 26, 2009 at 11:19 AM, Kees Bakker <kee...@xs...> wrote: > On Thursday 26 March 2009, Gerald Britton wrote: >> Dear Kees, >> >> Thanks for the feedback. It gives me further opportunity to explain >> how the class operates. > ... >> Also, about the indent parameter. The indentations are cumulative, >> which is why it needs to be supplied upon instantiation. > > Not if you would know the parent-child relation of the objects. > > ... >> Again, this is just for >> readability and does not affect rendering. > > I know, and it is under normal circumstances totally useless. That's why > I mentioned that it has value only while debugging. But Firebug is an > even better alternative for that. The python code of WebCal can be a > lot simpler if you leave out all the indent=True. At least you could > change the default to indent=True, but I am still not convinced it > belongs to the Html instance. BTW. The fact that you sometimes want > to not indent small things could be hidden away in the write function > too. It is not a valid argument to include "indent" in the Html class. > -- > Kees > -- Gerald Britton |