Re: [Gramps-devel] wrong commits

[Raphael A. <rap...@gm...>]

Benny,

Reverted the changes to __init__.py with 9787. Will also check the
other changes for similar errors. Thanks for spotting this.

Raphael

On Jan 12, 2008 11:47 PM, Benny Malengier <ben...@gm...> wrote:
> Raphael,
>
> some errors in your commit done by Brian. Can you please recheck all the
> changes you did in removing tabs and replacing by spaces if no equal errors,
> and fix the error I mention.
>
> I see the following error:
> http://gramps.svn.sourceforge.net/viewvc/gramps/trunk/src/Config/__init__.py?revision=9713&view=markup
>
> It should not be
>
> def __upgrade_gconf():
>     import _GrampsGconfKeys as GconfKeys
>     print "Upgrading INI file"
>     for key in default_value.keys():
>         data = GconfKeys.get(key)
>         set(key, data)
>
>     if not os.path.exists(INIFILE):
>         try:
>             __upgrade_gconf()
>         except ImportError:
>             print "Cannot upgrade GCONF settings"
>
> But:
>
> def __upgrade_gconf():
>      import _GrampsGconfKeys as GconfKeys
>      print "Upgrading INI file"
>      for key in default_value.keys():
>          data = GconfKeys.get(key)
>          set(key, data)
>
> if not os.path.exists(INIFILE):
>       try:
>          __upgrade_gconf()
>      except ImportError:
>          print "Cannot upgrade GCONF settings"
>
> So the if must start at position 0, as it was before your change. You can
> change tabs, but the alignment may not change.
>
> Benny
>