From: Brian M. <br...@gr...> - 2007-09-12 12:10:17
|
Zolt,=0A=0A>> >3. Usage of images in text reports is varying. Some reports = put the=0A>> >image in a paragraph, others in a cell, and yet others in the= =0A>> >document level. I would prefer not to put image inside a paragraph,= =0A>> >as that is for text. If the paragraph is used simply to be able to= =0A>> >define spacing around the image, then I would rather define Frames= =0A>> >with their own style and put the image in them. And this leads to=0A= >> >the next point:=0A>> =0A>> Each document does the best it can with imag= es. The ones that look=0A>> the best are the ones that allow the paragraph = text to wrap around=0A>> the image.=0A>Putting the image in a logical frame= , and the frame between 2=0A>paragraphs would not modify the final look of = the document. Note=0A>that there is no text in the same paragraph, in which= the report=0A>puts the image.=0A>Another advantage of using a frame could = sound more convincing: if we=0A>put the image and all other graphics into a= frame, it would be possible=0A>to add e.g. a title for an image, and one d= oes need to worry about the=0A>alignment of the title. E.g. I want to have = the title 'center' aligned=0A>with the image, but to have the image 'left' = aligned on the page.=0A=0AI guess I would need to see an example to underst= and what you are proposing. In the Detailed Descendant/Ancestor Reports, th= e text wraps around the images. That feature is desirable and would need to= be retained. I do like the idea of being able to add captions to the image= s - it has been asked for many times. But I don't think we need to make any= major changes to the report interface to support it. - just add a paramete= r to add_media_object() .=0A=0A>> >4. I would actually put not only the ima= ges, but also every graphics=0A>> >in a Frame. This would allow to have mix= ed reports in the (very)=0A>> >long term.=0A>> =0A>> I presume that you are= using the terms "paragraph", and "frame" in a=0A>> very specific way that = means something specific to GtkPrint. I don't=0A>> care how you implement i= t. Or are you suggesting a change to the=0A>> report interface?=0A>No, here= I'm using the terms as interface elements, i.e. generally.=0A>(That's anot= her issue that I do already follow something similar in the=0A>local implem= entation).=0A>So yes, I do suggest change in the interface, as also above i= n the=0A>previous point. With the phrase 'mixed' report I meant that a repo= rt=0A>would not need to care if it is a text or graphical report he is=0A>c= reating. He could simply add paragraphs and tables as in a text=0A>report, = but also drawings, which would be grouped in a frame.=0A=0AThat is an inter= esting proposition, but I see it being very difficult. There is one major d= ifference between text and graphical reports that complicates mixed reports= . For text reports, Gramps does not expose the layout and pagination to the= report. We either use an external library (reportlab, GtkPring) or let the= external viewer worry about it (OpenOffice.org). For graphical reports, th= e reports have to specify the exact location on the page for each graphical= element. So if you try to mix the two, you could end up with text running = over the graphics. We get around this by having book reports which allow gr= aphical and text reports to be combined.=0A=0A>> >5. I'd add line spacing a= s a property to Paragraph style.=0A>> =0A>> We already do. See set_top_marg= in() and set_bottom_margin() in the=0A>> ParagraphStyle class.=0A>No, that = is only for the space before and after the whole paragraph.=0A>What I meant= is the line spacing inside the paragraph.=0A>At the moment each doc genera= tor chooses that as they like.=0A=0AOh, right. If you really think people w= ould want that, I guess you could add it. But I would encourage you to firs= t concentrate on making each report consistent with how they do it now. Per= sonally, I would never want any spacing other than single space.=0A=0A>> >6= . Are the tables always left aligned? Possibly it would make sense=0A>> >to= add an alignment property to Table style.=0A>> =0A>> We already do that, t= oo. The table cells inherit the alignment from=0A>> the paragraph style tha= t is being used.=0A>Maybe I misunderstand here, but again what I mean is th= e whole table=0A>and not the single cells.=0A=0AUnless I am misunderstandin= g: If you set all paragraphs in all cells in a table to be right aligned (f= or example), then isn't the entire table right aligned? I'm not sure why yo= u need to specify an alignment for the entire table when you can already sp= ecify it for all cells.=0A=0AKeep up the good work Zolt!=0A=0A~Brian=0A=0A= =0A=0A |