Re: [Gramps-devel] Proposed changes for enhancing RelationView

[<bm...@ca...>]

Looks nice.

I'm not against this. If Don is ok, I don't mind merging this with a few
changes.

What I would like:
1/your self.collapsed_items = [] contains family handles that must be 
collapsed
So, different people will have the same families collapsed always.
I would find it better, as this is a person view, that all is person handle
related. So, you would need a dictionary, with keys the person handle of the
person shown.
Eg:
self.collapsed_items = {}
self.collapsed_items[person_handle] = [family_handle_to_collapse]

Like this, siblings and other stuff can be added to the same person.
This also does away with searching family handle in a list, so would be 
as fast
no matter how much collapsed nodes there are.
I understand you might like the feature of the same family being 
collapsed over
all persons, but personally I do not think that is a good feature.

2/do not use stock icons for how they look, use them for their meaning. Stock
icons are mapped to the system icon set, and can look very strange if you use
them for their looks, instead of for their meaning.
You can add gramps icons, eg, copy the stock icon you use of gnome iconset and
give it a gramps icon name, or find/create such a triangle icon (my 
preference,
less intrusive). See
http://www.gramps-project.org/wiki/index.php?title=Using_icons#How_to_add_an_Icon_to_GRAMPS
for the code of adding it.

3/why not think about a way of writing out a file with this setting on exit?
Would this slow down close/startup too much? There are fast ways to 
dump python
dictionaries to file, and read back in. Should be database name dependent I
think. Best go on ICQ and ask Don what he thinks. No needed feature for 
me, but
I'm sure some users will request it, so have the answer ready.

Benny


Quoting "Douglas S. Blank" <db...@cs...>:

> This proposal can be found at:
> http://www.gramps-project.org/wiki/index.php?title=RelationView_Enhancements
>
> Feedback (here or in wiki) appreciated!
>
> This page proposes and discusses possible changes to the RelationView of
> the GRAMPS GUI (Relationships).
>
> The first proposed change is the addition of expand/collapse buttons on
> the Parents and Family lines. This would allow the user to hide the
> details of the Parents, or a particular Family. This functionality helps a
> researcher focus their attention on one aspect (family) of the person.
>
> This differs from the "View" -> "Show Siblings" and "Show Details" in a
> couple of ways:
>
> # the expand/collapse is specific to a particular family
> # only lasts for the current session
>
> The change does remember what families have been collapsed, so when you
> return to a person, you get the same view as previous view (for this
> session).
>
> Example/Screenshot
>
> The first screenshot shows the RelationView as normal, but includes the
> "Collapse" icon (currently a magnifying glass with a minus sign.)
>
> The second screenshot shows the RelationView, and now includes the
> "Expand" icon (currently a magnifying glass with a plus sign.)
>
> Code
>
> The changes necessary to implement these changes can be found
> [http://bubo.brynmawr.edu/~dblank/relationview-01.patch here]. This can be
> applied to version gramps30.
>
> Options
>
> The families/parents to expand/collapse are kept in a list. Currently, the
> list is kept during the session, but could be cleared on changing the
> active person.
>
> The icon can be changed to something better. I wanted a triangle like on
> the people view (">" when collapsed, "V" when expanded) better there
> wasn't anything like that in stock gtk icons).
>
> Impact
>
> Requires a single phrase for translation: "Expand/Collapse section".
>
> Has a minimal screen impact.
>
> The handles of families that are collapsed are placed into a list. A
> substantial number of families would have to be collapsed for this to have
> an effect on performance. This is deemed to be unlikely.
>
> Future versions
>
> One could expand/collapse the siblings (which would make it so that the
> Show Siblings option would not be needed). However, this could make the
> screen too busy (considering that we would like to add some addition
> elements to this page).
>
> -Doug
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>  http://get.splunk.com/
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.