From: Kelvin L. <ne...@ki...> - 2006-10-10 12:48:03
|
Hi Alex, Thanks for taking the time to look over it. > 1. Probably an Edit button should be used to change the name > of the page (from New Page). I didn't get round to attaching a handler to the Edit button. If you're happy with that layout I'll see to that in a new patch. I couldn't find any way to make GTK notebook labels support renaming by the user, so I'll probably pop something up to ask for the new name. > 2. How are we going to decide what to include in the reports? > Is the intent to only include main page, and have others > for the researcher's private use? In that case, we probably need > to call New Page something like Private or Scratch or somesuch? Personally I'm not fussed either way. I'd be happy with a single default page with configurable extra pages, or with two default pages ("Public" and "Private" or "Main" and "Scratch" etc). > 3. Serialization: would we be better off by storing every > page's name and text as a tuple, instead of list of names > and list of texts? Just seems to be a clearer design. Yes that makes sense. How much of a big deal is it that the change to the database would make it fail on a previous version of Gramps (which would expect to see the old style of notes)? I guess this must happen quite often. As the patch stands, it supports reading in databases with the old notes format but once saved that database will look wrong to previous versions of Gramps. > There are minor UI improvements that can be done, > but basically I like it. Any other opinions? > Should we add this into gramps? I'll tie up some of the loose ends (Edit labels, XML conversion, tuple-storage) and send a new patch. Cheers, Kelvin. |