From: Tim A. <ti...@pr...> - 2005-08-21 10:45:46
|
Attached is a patch which addresses a couple of my whinges the other day about the comprehensive ancestors report. I think that making trivial changes to reports is as good a way as any to introduce oneself to the source code base. The changes are: - iff the option to start generations on a new page is selected, the sources list will also start on a new page - for people without photos, we leave the photo box completely blank, no text, no ugly black rectangles I expect the first to be a no-brainer, but perhaps the second may invite debate, since the initial author of this report (was it Tim Waugh?) presumably thought that ugly black rectangles all over the report was a feature, not a bug. Ugliness is in the eye of the beholder, so I'm quite willing to discuss the subject and possibly modify my patch if required. I've done all my testing of the changes with the pdf output option - please let me know if the other options have other subtleties that I've overlooked. Tim |