Menu

#17 check for readline version

closed
None
5
2006-11-01
2006-09-09
Anonymous
No

There's obviously a dependency to a recent version of
readline, you may want to add a corresponding check to
configure.in, so as to avoid problems such as these:

In file included from
/usr/local/include/readline/keymaps.h:37,
from
/usr/local/include/readline/readline.h:36,
from input.cc:86:
/usr/local/include/readline/rltypedefs.h:48: error:
`rl_command_func_t'
declared with an exception specification
/usr/local/include/readline/rltypedefs.h:51: error:
`rl_compentry_func_t'
declared with an exception specification
/usr/local/include/readline/rltypedefs.h:52: error:
`rl_completion_func_t'
declared with an exception specification
/usr/local/include/readline/rltypedefs.h:54: error:
`rl_quote_func_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:55: error:
`rl_dequote_func_t'
declared with an exception specification
/usr/local/include/readline/rltypedefs.h:57: error:
`rl_compignore_func_t'
declared with an exception specification
/usr/local/include/readline/rltypedefs.h:59: error:
`rl_compdisp_func_t'
declared with an exception specification
/usr/local/include/readline/rltypedefs.h:62: error:
`rl_hook_func_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:65: error:
`rl_getc_func_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:70: error:
`rl_linebuf_func_t'
declared with an exception specification
/usr/local/include/readline/rltypedefs.h:73: error:
`rl_intfunc_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:75: error:
`rl_icpfunc_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:76: error:
`rl_icppfunc_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:78: error:
`rl_voidfunc_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:79: error:
`rl_vintfunc_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:80: error:
`rl_vcpfunc_t' declared
with an exception specification
/usr/local/include/readline/rltypedefs.h:81: error:
`rl_vcppfunc_t' declared
with an exception specification
In file included from
/usr/local/include/readline/readline.h:37,
from input.cc:86:
/usr/local/include/readline/tilde.h:55: error:
`tilde_hook_func_t' declared
with an exception specification

Discussion

  • Ilya Goldberg

    Ilya Goldberg - 2006-11-01

    Logged In: YES
    user_id=306861

    There's a problem in the readline check specified in acinclude.m4.
    The check fails because the function rl_function_of_keyseq isn't in Readline 5.2 (current as of Oct,2006).
    Modifying acinclude.m4 to check for rl_completion_append_character instead fixes this problem (this is a check for readline > 2.1).

    Patch:
    --- acinclude-old.m4 2006-11-01 12:34:35.000000000 -0500
    +++ acinclude.m4 2006-11-01 12:13:01.000000000 -0500
    @@ -49,9 +49,9 @@
    done

    # Now try it again, to be sure it is recent enough.
    -# rl_function_of_keyseq appeared in version 2.0
    +# rl_completion_append_character appeared in version 2.1
    #
    -dnl AC_CHECK_FUNC(rl_function_of_keyseq, [wi_cv_lib_readline=yes],[
    +dnl AC_CHECK_FUNC(rl_completion_append_character, [wi_cv_lib_readline=yes],[
    dnl wi_cv_lib_readline=no;wi_cv_lib_readline_result="no (it is present but too old to use)"
    dnl ])
    AC_TRY_LINK([
    @@ -59,7 +59,7 @@
    ],[
    /* function-body */
    readline(0);
    - rl_function_of_keyseq(0);
    + rl_completion_append_character(0);
    ],[
    wi_cv_lib_readline=yes
    ],[

     
  • Scott Dattalo

    Scott Dattalo - 2006-11-01

    Logged In: YES
    user_id=11911

    Applied fix submitted by `iggie'

     
  • Scott Dattalo

    Scott Dattalo - 2006-11-01
    • assigned_to: nobody --> sdattalo
    • status: open --> closed
     

Anonymous
Anonymous

Add attachments
Cancel