Re: [Gpsbabel-code] Types conflict in an1.c

[Robert L. <rob...@us...>]

Dmitriy Geels wrote:

>    I found type names conflict in an1sym.h and an1.c. There is a type
>    defined GUID, which is one of favorite MS words. So there is a
>    conflict between GUID defined in winnt.h and one in an1.c.

Since we don't include winnt.h, why is this a problem?  It's not like
'GUID' is a reserved word.

>    Also there is a script make-an1sym.pl, which makes an1sym.h. I don't speak
>    Perl, so I need someone's help to change default_guids generation routine,
>    to make it unicode compatible:
>    {{0xb610bc70,{0x377e,  0x11d6, 0xaeb3}, {0x00, 0x01, 0x02, 0x31, 0x5f,
>    0xfd}}, "Hiker"}
>    to
>    {{0xb610bc70,{0x377e,  0x11d6, 0xaeb3}, {0x00, 0x01, 0x02, 0x31, 0x5f,
>    0xfd}}, _T("Hiker")}

No, you're going down a bad path here.  If you're going to mark every
string in the program this way, you're going to have a fork that
will be an ongoing maintenance hassle.  You need to provide this
converstion/markup thingy at the edges of input and output and not
every place it in the code.

If you have no intent to ever merge your port into the official tree,
then it's just a search and replace exercise in that file.


RJL