Re: [Gpsbabel-code] [PATCH] gui/serial_win: lowercase windows.h for case-sensitive FS

[Robert L. <rob...@gm...>]

We use the lowercase version in every other place.


On Thu, Apr 3, 2014 at 8:16 AM, tsteven4 <tst...@gm...> wrote:

>  I think this patch requires windows to be case insensitive if you are
> building on windows, i.e. the file distributed with the MS tools is named
> Windows.h.  My experience is that windows filesystems are case insensitive,
> but I don't know if this is always true.
>
>
> On 4/3/2014 6:11 AM, Robert Lipe wrote:
>
> Thanx.  Committed.
>
> On Thu Apr 03 2014 at 7:07:21 AM, Conrad Meyer <cs...@gm...> wrote:
>
>> ---
>> This was the only change I had to make to cross-build gpsbabelFE with
>> mingw64
>> on Linux.
>> ---
>>  gui/serial_win.cc | 2 +-
>>  gui/setup.iss     | 0
>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>  mode change 100755 => 100644 gui/setup.iss
>>
>> diff --git a/gui/serial_win.cc b/gui/serial_win.cc
>> index 7ebf025..f06a27a 100644
>> --- a/gui/serial_win.cc
>> +++ b/gui/serial_win.cc
>> @@ -24,41 +24,41 @@
>>  #if 0  // Does not require Windows 2000
>>
>>  static const char *deviceNames[] = {
>>    "com1:",
>>    "com2:",
>>    "com3:",
>>    "com4:",
>>    0
>>  };
>>
>>  void MainWindow::osLoadDeviceNameCombos(QComboBox *box)
>>  {
>>    for (int i=0; deviceNames[i]; i++) {
>>      box->addItem(deviceNames[i]);
>>    }
>>  }
>>
>>  #else // This code assumes Windows 2000 or later
>>
>>  // Uses QueryDosDevice(), Minimum supported: Windows 2000
>> Professional/Server
>> -#include <Windows.h>
>> +#include <windows.h>
>>  #include <stdio.h>
>>
>>  void MainWindow::osLoadDeviceNameCombos(QComboBox *box)
>>  {
>>    char DevList[64*1024-1];  // a single byte more, and certain versions
>> of windows
>>                              // always return QueryDosDevice()==0 &&
>> GetLastError()==ERROR_MORE_DATA.
>>                              // see
>> http://support.microsoft.com/kb/931305
>>    // Get a list of all existing MS-DOS device names. Stores one or more
>> asciiz strings followed by an extra null.
>>    DWORD res = QueryDosDeviceA(NULL, DevList, sizeof(DevList));
>>    if (res == 0)
>>    {
>>      DWORD err = GetLastError(); // could check for
>> ERROR_INSUFFICIENT_BUFFER, and retry with a larger buffer.
>>                                  // but DevList is already at the maximum
>> size it can be without running into kb 931305.
>>      // FIXME: This shold be a QMessageBox::warning() - RJL
>>      // fprintf(stderr,"QueryDosDevice() failed with %d.
>>  GetLastError()==%d.\n", res, err);
>>      (void) err;
>>      return;
>>    }
>>
>>    for (char *p=DevList; *p;) {
>> diff --git a/gui/setup.iss b/gui/setup.iss
>> old mode 100755
>> new mode 100644
>> --
>> 1.9.0
>>
>>
>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> Gpsbabel-code mailing list  http://www.gpsbabel.org
>> Gps...@li...
>> https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
>>
>
>
> ------------------------------------------------------------------------------
>
>
>
> _______________________________________________
> Gpsbabel-code mailing list  http://www...@li...https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
>
>
>