Re: [Gpsbabel-code] [ gpsbabel-Patches-1994175 ] iGo8 support
Brought to you by:
robertl
From: Dustin J. <du...@du...> - 2008-06-18 23:45:49
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=UTF-8" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> Yes, the newly attached igo8.c is the one with the modifications that you asked for.<br> <br> I'll look into the link you provided and get back to you.<br> <br> -Dustin<br> <br> <blockquote cite="mid:E1K...@d5..." type="cite"> <blockquote type="cite"> <pre wrap="">Comment By: Robert Lipe (robertl) </pre> </blockquote> <pre wrap=""><!---->Date: 2008-06-18 18:19 Message: Logged In: YES user_id=6013 Originator: NO See <a class="moz-txt-link-freetext" href="http://www.gpsbabel.org/htmldoc-development/fmt_garmin_gpi.html">http://www.gpsbabel.org/htmldoc-development/fmt_garmin_gpi.html</a> (or any of its siblings) to see what gets produced from the xmldoc/formats directory. Is this the igo8.c you want evaluated and potentially committed? Follow-up on the gpsbabel-code list, please. ---------------------------------------------------------------------- Comment By: Dustin Johnson (anaidioschrono) Date: 2008-06-18 12:47 Message: Logged In: YES user_id=2118621 Originator: YES I converted the types to the gbtypes. As far as ascii_to_unicode_2() function, I know it is a hack and I see quite a lot of string handling capability already present. I was hoping to be nudged in the right direction by someone who knows. I now byte swap the write_header constants. Is there an example of the type of doc that you want me to produce? I know it's just two paragraphs, but maybe if I had an example I would be more inline with what you are asking for. File Added: igo8.c ---------------------------------------------------------------------- Comment By: Robert Lipe (robertl) Date: 2008-06-17 22:46 Message: Logged In: YES user_id=6013 Originator: NO (this would have been better on the -code list...) The patch looks good. Thanx. If the structures have a fixed size, please use the types in gbtypes.h - this way we don't have problems if your code is built on a system where 'int' is 32 bits and 'unsigned long' is 64. (Yeah, they exist.) ascii_to_unicode_2() probably has a better counterpart in our CET. Most of our internal strings are actually UTF-8 and not ascii. Olaf could better guide us on the gpsbabel-code list. Don't the constants in write_header() potentially need to be byte-swapped? Also, if you can provide a paragraph or two of doc that would be helpful. We can handle the docbook markup, but you're more familiar with the program, how to use the files in question, the expectations of its users, etc. Thanx! ---------------------------------------------------------------------- You can respond by visiting: <a class="moz-txt-link-freetext" href="https://sourceforge.net/tracker/?func=detail&atid=489477&aid=1994175&group_id=58972">https://sourceforge.net/tracker/?func=detail&atid=489477&aid=1994175&group_id=58972</a> </pre> </blockquote> </body> </html> |