Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const_correctness" to your sources? I suggest to add the key word "const" to the type specifiers of parameters like "comment" for the function "gpe_set_comment".
Logged In: YES user_id=59853
Good eye :)
The gpe_* functions are internal functions, so we can change them without breaking compatibility.
In fact, we already have done so in CVS: The gpe_* functions aren't exported any more.
But we can keep this report around as a reminder for the next developer who does any internal cleanups/refactoring.
I suggest also an update for functions like the following. - cli_error_print http://gphoto.svn.sourceforge.net/viewvc/gphoto/trunk/gphoto2/gphoto2/main.h?revision=11153&view=markup
- dsc_dumpmem, dsc_msgprintf, dsc_errorprint http://gphoto.svn.sourceforge.net/viewvc/gphoto/trunk/libgphoto2/camlibs/panasonic/dc.h?revision=9336&view=markup
Log in to post a comment.
Logged In: YES
user_id=59853
Good eye :)
The gpe_* functions are internal functions, so we can change
them without breaking compatibility.
In fact, we already have done so in CVS: The gpe_* functions
aren't exported any more.
But we can keep this report around as a reminder for the
next developer who does any internal cleanups/refactoring.
I suggest also an update for functions like the following.
- cli_error_print
http://gphoto.svn.sourceforge.net/viewvc/gphoto/trunk/gphoto2/gphoto2/main.h?revision=11153&view=markup
- dsc_dumpmem, dsc_msgprintf, dsc_errorprint
http://gphoto.svn.sourceforge.net/viewvc/gphoto/trunk/libgphoto2/camlibs/panasonic/dc.h?revision=9336&view=markup