[Gnomebaker-devel] (forw) [tfheen@ubuntu.com: gnomebaker review for Ubuntu]

[Goedson P. <go...@gm...>]

Hello All,

I'm trying to have my gnomebaker packages included in Ubuntu's universe. It=
's
currently being reviewed and one of the reviewers sent me these comments ab=
out
the upstream source and I hope you could address these issues if possible.

Best Regards,

Goedson

----- Forwarded message from Tollef Fog Heen <tf...@ub...> -----

Date: Thu, 10 Mar 2005 12:12:57 +0100
To: go...@de...
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)
From: Tollef Fog Heen <tf...@ub...>
Subject: gnomebaker review for Ubuntu


Hi,

I've reviewed your gnomebaker package as available on
http://people.debian.org/~goedson/packages/ubuntu/hoary/gnomebaker/releases=
/src/

Summary:

[ removed some comments about the packaging ]

The upstream source has a number of issues, some which I would really
like to get fixed, some which aren't so important.

- Automake 1.4

Automake 1.4 is old.  Very old.  Please, please, please don't write
new software which uses automake 1.4.

- Weird, empty files

: tfheen@thosu /tmp/gnomebaker-0.3 > find -size 0
./README
./ABOUT-NLS
./AUTHORS
./NEWS
./intl/Makefile.am
./po/ChangeLog

Apart from the intl/Makefile.am, shipping empty files is just a
waste.  This is probably because upstream just used automake instead
of automake --foreign

- Executable text files

find -perm +u+x -not -type d | xargs -n 1 file | grep -v =ABexecutable=BB|
wc -l
52

A bunch of the files in src/ are marked as executable, so is the
AUTHORS file, the ChangeLog and a (seemingly random) set of other
files.  It's a purely an aesthetical issue, though.

- Missing and wrongly licensed files.

I was at first happy to see that all the files in the src/ directory
bore the GPL boilerplate.  That's good.  However, a lot of them miss
copyright information:

 * Created by: luke <luke@dhcp-45-369>

(from burn.c).  This is a bit too little identifying information.

 * Created by: Luke Biddell <Email>

(datacd.h); this is a bit better, but an email address would be
preferred.  Also, writing

* Copyright Luke Biddell <luk...@ya...> 2004, 2005
would be so much better.

Some also miss author information completely (gbcommon.c is an
example).

A funny (but a bit sad) example is the gbcommon.h:

 *  Copyright  2004  User
 *  Email

- Using -lvorbisfile instead of pkg-config

the src/Makefile.am uses an explicit -lvorbisfile instead of the
output of pkg-config --libs vorbisfile (through configure.in).

Thanks for looking into those issues! :)

--
Tollef Fog Heen                                                        ,''`=
.
UNIX is user friendly, it's just picky about who its friends are      : :' =
:
                                                                      `. `'
                                                                        `-

----- End forwarded message -----


--=20
Goedson Teixeira Paixao