Re: [glean-dev] Only test one visual when --quick parameter is used

[Brian P. <br...@vm...>]

Nicolai Hähnle wrote:
> A lot of drivers expose a large number of visuals. So even though the --quick 
> option reduces the time taken by texCombine significantly, "quick" is still 
> kind of the wrong adjective to describe glean with the --quick option.

I guess I'm in the habbit of running glean on just one visual with the 
--visual option when I want a quick run.


> The attached patch (which I've taken the liberty to apply to the copy of glean 
> in piglit for now) changes the behaviour of --quick so that only the first 
> selected visual gets selected, in the hope of making those test runs a bit 
> less annoying for people.
> 
> There's a potential pitfall here in that this might select a visual on which 
> certain tests don't apply. On the limited systems I've tested here, the first 
> visual is always double-buffered with Z buffer and stencil, so I hope this 
> isn't a problem in practice.

I think we really need to make sure that a visual with at least a Z 
buffer is chosen.  Otherwise, quite a few tests won't run.

I'll see if I can come up with a better patch.

-Brian