Re: [Gfs-devel] Problem with gfs_cell_advected_face_value

[Jose M. López-H. S. <jos...@gm...>]

Hi Stephane,

Could you please send me a patch (against the latest gerris-devel)
> implementing your changes and a way to reproduce the crash and I will
> have a look.
>

Just a comment  of patches I am sending:

Sun Oct 23 17:05:36 CEST 2011  "Jose Lopez-Herrera Sanchez" <
jos...@gm...>"
  * slight changes in electrohydro.c to allow compilation

The cosmetics changes you did to the charge implicit scheme left two
functions with the same name .This patch just correct this.

Sun Oct 23 17:06:41 CEST 2011  "Jose Lopez-Herrera Sanchez" <
jos...@gm...>"
  * GfsOutputSectionFlux moved to oputput.c

Self-explanatory.

*Additional comment:*

Right now GfsOutputSectionFlux is conceived to work with Godunov advected
VariableTracers not with  VOF advected ones (TracerVOF & VOFConcentrations)
which uses vof_flux() in vof.c . I have to confess that I do not understand
most of this part of the code (the vof advection) with the new "multiband"
approach. So, I feel I will need a lot of help from you  in order to be able
to extend GfsOuputSectionFlux to VOF advected variables. To this lack of
understanding contribute that this part, for a clumsy like me, is, somehow
"less guided" than the godunov advection part  since it has
fewer exported functions being  them of longer extension.  I wonder if it
would be a good idea for this type of advection to recover old procedures
already deleted like your vof_face_values( ) which used  fine_fraction(),
coarse_fraction() to set s->f[d ].v for the VOF variable.


Cheers

Jose