[Geotools-devel] Request for Feedbacks: integrating unsupported's gt-mark-wkt into gt-render

[Daniele R. <dan...@ge...>]

Hi Guys,
We would like to move the code available on mark-wkt module within
gt-render.
It is widely used by styles defined to render marks such as arrows,
circles, and other shapes in general (based on WKT definitions).

Moreover, we have worked on a submodule which allows to render windbarbs:
http://en.wikipedia.org/wiki/Station_model#mediaviewer/File:Wind_barbs.gif
Some samples here:
http://www.geo-solutions.it/blog/developers-corner-supporting-wind-barbs-geoserver-geotools/

Having these rendered additions integrated in gt-render module would
represent a great improvement of the rendering engine capabilities.
In addition, this will also avoid the need of building that part separately
and manually integrate its jar within  the geoserver war

Mark-WKT dependencies reported by maven dependency:tree
=============================================

[INFO]
------------------------------------------------------------------------
[INFO] *Building WKT symbols addition to the renderer 12-SNAPSHOT*
[INFO]
------------------------------------------------------------------------
[INFO] org.geotools:gt-mark-wkt:jar:12-SNAPSHOT
[INFO] +- org.geotools:gt-main:jar:12-SNAPSHOT:compile
[INFO] |  +- org.geotools:gt-api:jar:12-SNAPSHOT:compile
[INFO] |  |  \- org.geotools:gt-referencing:jar:12-SNAPSHOT:compile
[INFO] |  |     +- java3d:vecmath:jar:1.3.2:compile
[INFO] |  |     +- commons-pool:commons-pool:jar:1.5.4:compile
[INFO] |  |     +- org.geotools:gt-metadata:jar:12-SNAPSHOT:compile
[INFO] |  |     |  \- org.geotools:gt-opengis:jar:12-SNAPSHOT:compile
[INFO] |  |     |     \- net.java.dev.jsr-275:jsr-275:jar:1.0-beta-2:compile
[INFO] |  |     \- jgridshift:jgridshift:jar:1.0:compile
[INFO] |  +- com.vividsolutions:jts:jar:1.13:compile
[INFO] |  \- org.jdom:jdom:jar:1.1.3:compile
[INFO] +- org.geotools:gt-sample-data:jar:12-SNAPSHOT:test
[INFO] +- org.geotools:gt-render:jar:12-SNAPSHOT:compile
[INFO] |  +- org.geotools:gt-coverage:jar:12-SNAPSHOT:compile
[INFO] |  |  +- javax.media:jai_imageio:jar:1.1:compile
[INFO] |  |  +-
it.geosolutions.imageio-ext:imageio-ext-tiff:jar:1.1.10:compile
[INFO] |  |  |  +-
it.geosolutions.imageio-ext:imageio-ext-utilities:jar:1.1.10:compile
[INFO] |  |  |  \- javax.media:jai_codec:jar:1.1.3:compile
[INFO] |  |  +- org.jaitools:jt-zonalstats:jar:1.3.1:compile
[INFO] |  |  \- org.jaitools:jt-utils:jar:1.3.1:compile
[INFO] |  \- org.geotools:gt-cql:jar:12-SNAPSHOT:compile
[INFO] \- javax.media:jai_core:jar:1.1.3:compile

As you can see, there are no unsupported or weird dependencies inherited by
that module.
Only core one such as main, and render itself.

About code coverage, this is the cobertura report:

Package # Classes Line Coverage <help.html> Branch Coverage <help.html>
Complexity <help.html> *All Packages*7 74%
389/520
 59%
176/298
9,923org.geotools.renderer.markwkt
<frame-summary-org.geotools.renderer.markwkt.html> 3 88%
105/119
73%
25/34
4,571 org.geotools.renderer.windbarbs
<frame-summary-org.geotools.renderer.windbarbs.html> 4 70%
284/401
 57%
151/264
11,895
What do you think about it?
(Obviously, a JIRA will be created for that.)

Cheers,
Daniele

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==

Ing. Daniele Romagnoli
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------