From: David W. <dwi...@op...> - 2011-02-24 22:01:39
|
On Wed, Feb 23, 2011 at 8:52 PM, Justin Deoliveira <jde...@op...>wrote: > I think the logic looks ok in in LocalWorkspaceResourceAccessManager based > on my limited understanding of the new api. Unless I am mistaken however > the intersection(WorkspaceAccessLimits,WorkspaceAccessLimits) method is > unused? > That's true (it's not used) but I moved these to the ResourceAccessManagerWrapper and left it in for consistency. I also made them and the LocalWorkspaceResourceAccessManager aware of the narrower types of DataAccessLimits. An updated patch is attached to the same ticket. One concern I had was in finding the intersection of the ROI for CoverageAccessInfo - the intersection of two MultiPolygons may be a Polygon (or other types? I am not sure). I suspect somewhere in GeoTools there is a method to correct for this, but in my patch I simply put in an if/else statement and ignored the possibility that they might intersect in a point or something. -- David Winslow OpenGeo - http://opengeo.org/ > Past that I have the same feedback as Andrea. It looks like some type > narrowing methods are required. It might be nice to throw them in the > wrapper subclass along with the intersection methods... since other wrappers > will probably face the same issues. Maybe not. I leave that up to you. > > On Wed, Feb 23, 2011 at 1:55 PM, David Winslow <dwi...@op...>wrote: > >> I took a stab at addressing the issue (both the disabled extension point >> and the refactoring to ResourceAccessManager) in the patch attached to >> http://jira.codehaus.org/browse/GEOS-4397. >> >> -- >> David Winslow >> OpenGeo - http://opengeo.org/ >> >> >> On Wed, Feb 16, 2011 at 3:17 PM, Justin Deoliveira <jde...@op...>wrote: >> >>> Right, the virtual servies manager is a wrapper. I believe we put it in >>> the app context to make it easy to disable on 2.0.x where we did not want it >>> to engage by default (although the client that funded the work did need it >>> on 2.0.x). So I am all for being explicit about creating it in >>> SecureCatalogImpl. >>> >>> >>> On Wed, Feb 16, 2011 at 11:34 AM, Andrea Aime < >>> and...@ge...> wrote: >>> >>>> >>>> On Wed, Feb 16, 2011 at 7:04 PM, Justin Deoliveira < >>>> jde...@op...> wrote: >>>> >>>>> This is most likely due to the virtual services stuff which installs >>>>> its own DataAccessManager. And as you can see the lookup is not prepared to >>>>> handle multiple access managers. If i remember correctly when i made that >>>>> change I figured this might come up. >>>>> >>>>> Not sure how to best handle this. My first thought would be to do a >>>>> look up for all of them in the application context and wrap them up in a >>>>> composite manager. But would like to hear Andrea weigh in. >>>>> >>>> >>>> Yes, the plugin system was created so that there can be only one >>>> security manager around. >>>> Which makes sense, you don't want to have a russian roulette of what the >>>> security subsystem will be in case >>>> there is more than one, depending on the JVM chosen, the container and >>>> the eventual alignment of planets in >>>> the solar system ;-) >>>> >>>> Now, the virtual services thing as far as I can see is there to wrap and >>>> alter the security settings, it's not >>>> really the security manager, it's a just wrapper around it. >>>> >>>> So imho it should not be part of the app context, but be created around >>>> the chosen security manager >>>> by the secure catalog impl instead. >>>> >>>> Btw, I did not touch that part since I did not know exactly what it was >>>> doing, but the wrapper should >>>> be updated to be a ResourceAccessManager instead >>>> >>>> Cheers >>>> Andrea >>>> >>>> -- >>>> ------------------------------------------------------- >>>> Ing. Andrea Aime >>>> GeoSolutions S.A.S. >>>> Tech lead >>>> >>>> Via Poggio alle Viti 1187 >>>> 55054 Massarosa (LU) >>>> Italy >>>> >>>> phone: +39 0584 962313 >>>> fax: +39 0584 962313 >>>> mob: +39 333 8128928 >>>> >>>> http://www.geo-solutions.it >>>> http://geo-solutions.blogspot.com/ >>>> http://www.youtube.com/user/GeoSolutionsIT >>>> http://www.linkedin.com/in/andreaaime >>>> http://twitter.com/geowolf >>>> >>>> ------------------------------------------------------- >>>> >>> >>> >>> >>> -- >>> Justin Deoliveira >>> OpenGeo - http://opengeo.org >>> Enterprise support for open source geospatial. >>> >>> >> > > > -- > Justin Deoliveira > OpenGeo - http://opengeo.org > Enterprise support for open source geospatial. > > |