Re: [Geoserver-devel] [jira] Created: (GEOS-2097) LEGEND_OPTIONS: forceLabels doesn't work

[Chris H. <ch...@op...>]

This is the first I've seen of the patch, must have missed it when it 
first went by.

To make sure someone continues to look at it the thing to do is to put 
'fix for' as an upcoming version.  Then it will show up in the list of 
bugs that we're actually trying to get done.  Maybe it won't make it in 
(though bugs that have working patches have a high chance of getting in, 
and if they have a test case too we do all we can to ensure they're in 
asap), but at the very least it will be evaluated and moved to the next 
version.  We comb through the .x milestones a lot less often.

I've scheduled for 1.7.1.  Justin is running the RC2 ship, so if it's 
minor enough and truly just bug fix he may reschedule and get it in for 
that release.  A test case would be really great, so that we don't 
regress on this.  Apologies that it slipped out of notice, we should 
have got it in earlier.

best regards,

Chris



Wayne Fang wrote:
> I was wondering if anything had been done about this patch?  This 
> affects 1.7.x, not just 1.6.x and trunk.
> 
> Thanks,
> Wayne
> 
> Wayne Fang (JIRA) wrote:
>> LEGEND_OPTIONS:  forceLabels doesn't work
>> -----------------------------------------
>>
>>                  Key: GEOS-2097
>>                  URL: http://jira.codehaus.org/browse/GEOS-2097
>>              Project: GeoServer
>>           Issue Type: Bug
>>           Components: Google Earth KML Output, WMS
>>     Affects Versions: 1.6.x
>>             Reporter: Wayne Fang
>>             Assignee: Andrea Aime
>>             Priority: Minor
>>              Fix For: 1.6.x
>>          Attachments: legendOptions_Aug05_2008.patch
>>
>> [legend text forced ON|http://localhost:8080/geoserver/wms?service=WMS&request=GetMap&format=application/vnd.google-earth.kml+XML&width=1024&height=1024&srs=EPSG:4326&layers=topp:states&styles=population&bbox=-180,-90,180,90&format_options=LEGEND:true;KMSCORE:0;KMATTR:true;&legend_options=forceLabels:on]
>> [legend text forced OFF|http://localhost:8080/geoserver/wms?service=WMS&request=GetMap&format=application/vnd.google-earth.kml+XML&width=1024&height=1024&srs=EPSG:4326&layers=topp:states&styles=population&bbox=-180,-90,180,90&format_options=LEGEND:true;KMSCORE:0;KMATTR:true;&legend_options=forceLabels:off]
>>
>> Doing a wms request with a legend and specifying the forceLabels legend option doesn't work.  The parameter gets dropped when the getLegendGraphicUrl is encoded to KML.
>>
>> The included patch takes the raw legend_options kvp string and passes it along as an optional kvpArray (instead of always passing 'null').
>>
>> This also affects (and fixes) trunk.
>>
>>   
> 
>