From: Justin D. <jde...@op...> - 2006-07-31 17:25:20
|
Saul Farber wrote: > Hey all, > > I've got two questions. > > 1) What's up with formatting on trunk? For example, in the > geoserver-trunk/pom.xml and geoserver-trunk/web/pom.xml, everything > seems pretty funky starting right around line 157. Also in > GeoserverDataDirectory.java, there are strangely indented lines floating > around. Is there an official policy about formatting? I'd *love* to > just hit "ctrl-f" in eclipse and make it all look real pretty, but that > makes it impossible for me to use '$svn diff' effectively. Is there > something auto-formatting the code that's doing something screwy? > Alternatively, is this problem isolated to me? Anyone else have > strangely formatted trunk code? > Yes! I would be in full support of automated code formatting. We could do something similar to geotools and have it run as part of the maven build. > > 2) I've found a couple of bugs on the trunk. > > For example, in GeoserverDataDirectory.java on lines 75 and 86 there are > a pair of if-clauses which check for data directory over-ride > information. In both of these if-clauses control returns from the > method before the 'locator' static object has been initialized. I added > the line: > > loader = new GeoServerResourceLoader( dataDir ); > > right before the 'return dataDir' calls on 92 and 81 and my problems > with using -DGEOSERVER_DATA_DIR=... were fixed. What's the etiquette > for committing these kinds of fixes? I'm guessing that for a fix such > as the above, a message to the list might be enough. For something more > major, clearly some kind of consensus needs to be reached. Am I in the > right ballpark? > I changed this recently, the fix sounds straight forward. You can throw it in jira if you want as a 1.4.0 fix as it is a pretty cruicial one. -Justin > > Thanks, > > --saul > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Geoserver-devel mailing list > Geo...@li... > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > !DSPAM:1004,44ce372f80361425493344! > -- Justin Deoliveira The Open Planning Project jde...@op... |