Re: [Ganglia-developers] Network stats when doing bonding

[Martin K. <kn...@kn...>]

Hi Alex,

 this is another example of where we actually want/need a way to
specify which network interfaces we are interested in.

 So, please open a BZ entry and assign to me. I am not sure, whether
your patch is what we need, but we need/want something.

Martin

--- Alex Balk <dv...@ac...> wrote:

> Hi all,
> 
> 
> We've come across a problem when bonding multiple interfaces under
> Linux. The reported network information was counted both for the
> bonding
> interface and for the slave interfaces - incorrectly doubling the
> network usage stats.
> 
> 
> I'm attaching a patch which solves the issue - it supports up to 10
> bonding interfaces.
> 
> If you want me to open a bugzilla entry, let me know.
> 
> 
> Cheers,
> 
> Alex
> 
> > --- metrics.c	2006-04-17 17:42:55.000000000 +0300
> +++
> /usr/local/src/ganglia-3.0.3.new/srclib/libmetrics/linux/metrics.c
> 2006-06-22 12:01:16.000000000 +0300
> @@ -151,7 +151,7 @@
>       while (*p != 0x00 )
>         {
>         p = index(p, ':')+1; /*  skip past the interface tag portion
> of this line */
> -       if ( (*(p-2) != 'o') && (*(p-3) != 'l') )
> +       if ( ((*(p-2) != 'o') && (*(p-3) != 'l')) && ((*(p-3) != 'd')
> && (*(p-4) != 'n') && (*(p-5) != 'o') &&(*(p-6) != 'b')) )
>            {
>            t = strtod( p, &p );
>            bytes_in += t;
> @@ -209,7 +209,7 @@
>       while (*p != 0x00 )
>         {
>         p = index(p, ':')+1; /*  skip past the interface tag portion
> of this line */
> -       if ( (*(p-2) != 'o') && (*(p-3) != 'l') )
> +       if ( ((*(p-2) != 'o') && (*(p-3) != 'l')) && ((*(p-3) != 'd')
> && (*(p-4) != 'n') && (*(p-5) != 'o') &&(*(p-6) != 'b')) )
>            {
>            t = strtod( p, &p );
>            bytes_in += t;
> @@ -267,7 +267,7 @@
>       while (*p != 0x00 )
>         {
>         p = index(p, ':')+1; /*  skip past the interface tag portion
> of this line */
> -       if ( (*(p-2) != 'o') && (*(p-3) != 'l') )
> +       if ( ((*(p-2) != 'o') && (*(p-3) != 'l')) && ((*(p-3) != 'd')
> && (*(p-4) != 'n') && (*(p-5) != 'o') &&(*(p-6) != 'b')) )
>            {
>            t = strtod( p, &p );
>            bytes_in += t;
> @@ -328,7 +328,7 @@
>         {
>         p = index(p, ':')+1; /*  skip past the interface tag portion
> of this line */
>         debug_msg(" Last two chars: %c%c\n", *p-2, *p-1 );
> -       if ( (*(p-2) != 'o') && (*(p-3) != 'l') )
> +       if ( ((*(p-2) != 'o') && (*(p-3) != 'l')) && ((*(p-3) != 'd')
> && (*(p-4) != 'n') && (*(p-5) != 'o') &&(*(p-6) != 'b')) )
>            {
>            debug_msg(" Last two chars: %c%c\n", *p-2, *p-1 );
>            t = strtod( p, &p );
> > All the advantages of Linux Managed Hosting--Without the Cost and
> Risk!
> Fully trained technicians. The highest number of Red Hat
> certifications in
> the hosting industry. Fanatical Support. Click to learn more
>
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642>
_______________________________________________
> Ganglia-developers mailing list
> Gan...@li...
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
> 


------------------------------------------------------
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de