[Ganglia-developers] Strange gaps in RRDs

[Martin K. <kn...@kn...>]

--- rrd_helpers.c-orig  2006-01-25 16:14:16.000000000 +0100
Hi friends,

 on the ganglia-general list was discussion about gaps in the RRD
graphs.

 While it may not be the only problem the original poster saw, I
managed to reproduce the effect by inserting things like "bla" int an
int16 metric via gmetric. 

 I found that the following change to gmetad solved the problem for me.
The bogus values are still logged, but we do not return an error
upstreams. Could this create new problems? 

 In the meanwhile I have checked in a bit of code that does sanity
checking on numeric gmetric parameters. So this situation should not
happen again.

 I still do not think that gmetad should stop working  when there is
junk in the XML stream.

Cheers
Martin

+++ rrd_helpers.c       2006-01-25 16:10:27.000000000 +0100
@@ -54,7 +54,7 @@
       {
          err_msg("RRD_update (%s): %s", rrd, rrd_get_error());
          pthread_mutex_unlock( &rrd_mutex );
-         return 1;
+         return 0;
       }
    /* debug_msg("Updated rrd %s with value %s", rrd, val); */
    pthread_mutex_unlock( &rrd_mutex );




------------------------------------------------------
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de