RE: [Ganglia-developers] gmetad umask trouble

[Bernard L. <bl...@bc...>]

Hey Martin:

Any luck getting a hold of Matt?

Cheers,

Bernard=20

> -----Original Message-----
> From: gan...@li...=20
> [mailto:gan...@li...] On=20
> Behalf Of Martin Knoblauch
> Sent: Friday, October 28, 2005 4:42
> To: Seth Alves; gan...@li...
> Subject: Re: [Ganglia-developers] gmetad umask trouble
>=20
> Hi Seth,
>=20
>  thanks. I will take this one before 3.0.2.
>=20
>  Someone else hinted that your pidfile stuff may have problems when a
> pidfile without a process exists. I haven't checked myself.=20
> do you have
> any comments?
>=20
> Cheers
> Martin
>=20
> --- Seth Alves <se...@li...> wrote:
>=20
> >=20
> > Hello, here is a patch to my last patch.
> >=20
> > I set the umask to be too restrictive, and then left it. =20
> When gmetad
> >=20
> > tries to make new directories, they come out like this:
> >=20
> > drw-r--r-x  __SummaryInfo__/
> >=20
> > and then it can't write new files into them.
> >=20
> > 	-seth
> >=20
> >=20
> > --- daemon_init.c       2005-10-27 14:19:07.609392857 -0700
> > +++ daemon_init.c-patched       2005-10-27 14:18:56.368240894 -0700
> > @@ -27,6 +27,7 @@
> >   update_pidfile (char *pidfile)
> >   {
> >     pid_t pid;
> > +  mode_t prev_umask;
> >     FILE *file;
> >=20
> >     /* make sure this program isn't already running. */
> > @@ -43,7 +44,7 @@
> >       }
> >=20
> >     /* write the pid of this process to the pidfile */
> > -  umask(0112);
> > +  prev_umask =3D umask (0112);
> >     unlink(pidfile);
> >=20
> >     file =3D fopen (pidfile, "w");
> > @@ -55,6 +56,7 @@
> >       }
> >     fprintf (file, "%d\n", (int) getpid());
> >     fclose (file);
> > +  umask (prev_umask);
> >   }
> >=20
> >=20
> > -------------------------------------------------------
> > This SF.Net email is sponsored by the JBoss Inc.
> > Get Certified Today * Register for a JBoss Training Course
> > Free Certification Exam for All Training Attendees Through End of
> > 2005
> > Visit http://www.jboss.com/services/certification for more
> > information
> > _______________________________________________
> > Ganglia-developers mailing list
> > Gan...@li...
> > https://lists.sourceforge.net/lists/listinfo/ganglia-developers
> >=20
> >=20
>=20
>=20
> ------------------------------------------------------
> Martin Knoblauch
> email: k n o b i AT knobisoft DOT de
> www:   http://www.knobisoft.de
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by the JBoss Inc.
> Get Certified Today * Register for a JBoss Training Course
> Free Certification Exam for All Training Attendees Through End of 2005
> Visit http://www.jboss.com/services/certification for more information
> _______________________________________________
> Ganglia-developers mailing list
> Gan...@li...
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
>=20