Re: [Ganglia-developers] A bug in the CVS version gmond(2.5.4)

[Federico S. <fd...@sd...>]

On Wednesday, June 4, 2003, at 02:14 AM, lv jin wrote:

> The CVS version gmond's xml dtd output is truncated.

Ahh, right. That is mine. I added to the dtd, and increased the buffer 
size for gmetad, but not gmond. Thanks for catching this, I'll 
incorporate your patch.

-fds

>
> telnet localhost 8649 give the following output:
> ----------------------------------
> Trying 127.0.0.1...^M
> Connected to localhost.^M
> Escape character is '^]'.^M
> <?xml version="1.0" encoding="ISO-8859-1"
> standalone="yes"?>
> <!DOCTYPE GANGLIA_XML [
>    <!ELEMENT GANGLIA_XML (GRID)*>
>       <!ATTLIST GANGLIA_XML VERSION CDATA #REQUIRED>
>       <!ATTLIST GANGLIA_XML SOURCE CDATA #REQUIRED>
>    <!ELEMENT GRID (CLUSTER | GRID | HOSTS | METRICS)*>
>       <!ATTLIST GRID NAME CDATA #REQUIRED>
>       <!ATTLIST GRID AUTHORITY CDATA #REQUIRED>
> ...
> ...
>    <!ELEMENT METRICS EMPTY>
>       <!ATTLIST METRICS NAME CDATA #REQUIRED>
>       <!ATTLIST METRICS SUM CDATA #REQUIRED>
>       <!ATTLIST METRICS NUM CDATA #REQUIRED>
>       <!ATTLIST METRICS TYPE (string | int8 | uint8 |
> int1<GANGLIA_XML VERSION="2.5.4" SOURCE="gmond">
> ...
> ...
> -----------------------------------------
> The last line of dtd is truncated.
>
> it's because buffrd_print()'s buffer is too small for
> the new dtd.
>
> i make a patch that simply increase the buffer's size.
> :-)
>
> patch:
> diff -Naur monitor-core/gmond/server.c
> monitor-core-lj/gmond/server.c
> --- monitor-core/gmond/server.c 2002-12-09
> 05:25:56.000000000 +0000
> +++ monitor-core-lj/gmond/server.c      2003-06-04
> 09:32:27.000000000 +0000
> @@ -33,7 +33,7 @@
>  {
>     int rval, len;
>     va_list ap;
> -   char buf[2048];
> +   char buf[3072];
>
>     va_start (ap, fmt);
>
>
> __________________________________
> Do you Yahoo!?
> Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
> http://calendar.yahoo.com
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by:  Etnus, makers of TotalView, The 
> best
> thread debugger on the planet. Designed with thread debugging features
> you've never dreamed of, try TotalView 6 free at www.etnus.com.
> _______________________________________________
> Ganglia-developers mailing list
> Gan...@li...
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
>
Federico

Rocks Cluster Group, San Diego Supercomputing Center, CA