[Ganglia-bugzilla] [Bug 96] Illegal attempt to update RRDs with multiple gmetad

[bugzilla-daemon@Millennium.Berkeley.EDU]

http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=96


Nick Satterly <nic...@gm...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nic...@gm...




--- Comment #1 from Nick Satterly <nic...@gm...>  2011-02-09 12:57:17 ---
I've discovered that the error is generated when the last cluster listed in the
XML reported by the downstream gmetad is written to disk a second time. This
happens because the section of code to write the cluster summary when it parses
a </CLUSTER> end tag also gets triggered by a </GRID> end tag.

In process_xml.c there is a switch statement for GRID and CLUSTER tags where I
believe there is a "break" missing -- exactly where the "No break" comment is!

   switch ( xt->tag )
      {
         case GRID_TAG:
            rc = endElement_GRID(data, el);
            /* No break. */

         case CLUSTER_TAG:
            rc = endElement_CLUSTER(data, el);
            break;

         default:
               break;
      }


When I put a break exactly where the "No break" comment is and recompile gmetad
I don't get any more RRD update errors.


-- 
Configure bugmail: http://bugzilla.ganglia.info/cgi-bin/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.