Re: [Ganglia-developers] [Ganglia-svn] SF.net SVN: ganglia: [1538]trunk/monitor-core/Makefile.am

[Brad N. <BNI...@no...>]

>>> On 7/9/2008 at 9:25 PM, in message <20080710032541.GB28512@tapir>, Carlo
Marcelo Arenas Belon <ca...@sa...> wrote:
> On Wed, Jul 09, 2008 at 11:39:16AM -0600, Brad Nicholes wrote:
>> >>> On 7/8/2008 at 8:33 PM, in message
>> <E1K...@sc...>,
>> <ca...@us...> wrote:
>> > Revision: 1538
>> >           http://ganglia.svn.sourceforge.net/ganglia/?rev=1538&view=rev 
>> > Author:   carenas
>> > Date:     2008-07-08 19:33:06 -0700 (Tue, 08 Jul 2008)
>> > 
>> > Log Message:
>> > -----------
>> > build: include contrib in package
>> > 
>> > Modified Paths:
>> > --------------
>> >     trunk/monitor-core/Makefile.am
>> > 
>> > Modified: trunk/monitor-core/Makefile.am
>> > ===================================================================
>> > --- trunk/monitor-core/Makefile.am	2008-07-09 01:14:50 UTC (rev 1537)
>> > +++ trunk/monitor-core/Makefile.am	2008-07-09 02:33:06 UTC (rev 1538)
>> > @@ -6,7 +6,7 @@
>> >  GMETAD_SUBDIR = 
>> >  endif
>> >  
>> > -EXTRA_SUBDIRS = "./web gmetad-python"
>> > +EXTRA_SUBDIRS = "web gmetad-python contrib"
>> >  EXTRA_DIST_FILES = 
>> >  INCLUDES = @APR_INCLUDES@
>> >  
>> 
>> Do we really want contrib included in the package?  I thought contrib was 
> just a place to put extra stuff that might someday be migrated into the 
> package.
> 
> Strange, I thought it was just left out of the package by mistake, as the
> documentation seems to imply the files are in a local directory.
> 
> I was specially interested in getting ganglia-rrd-modify.pl somehow
> distributed with ganglia, as it will be very useful as an aid for data
> migrations like the ones that AIX users might need when upgrading to 3.1
> (where the disk metric units has changed).
> 

I agree, the ganglia-rrd-modify.pl would be a good addition.  But doesn't that mean that we simply move it out of contrib/ and into scripts/ ?  Once we all give it our +1's of course.

Brad