From: Brad N. <BNI...@no...> - 2008-01-24 16:36:42
|
>>> On 1/23/2008 at 11:23 PM, in message <Pin...@pr...>, Matthias Blankenhaus <mat...@sg...> wrote: > Howdy ! >=20 > As announced during our last meeting in SF I finally started to work = on=20 > this module. Came out that I need to extend gmond and the module area > a bit in order to support my IPMI module. >=20 > Essentially, I need to be able to spoof metrics from DSO modules. I = also > need access to gmond's host list. I figured these two feature are of > general interest for Ganglia and thus are worth integrating. >=20 > I began working on metric spoofing first and I have now a running=20 > prototype. I would like to propose this new feature through a series > of patches roughly in this order and with this content: >=20 > (01) Minor gmond cleanup stuff > (02) Modified data structures and new types to support spoofing > (03) Registration code for module spoof handler > (04) Modified metric collection logic to support spoofing > (05) Spoofing test module >=20 > After this I would work on exporting gmond's host list and then > eventually on the IPMI module. =20 >=20 > I fully expect and hope that we will have healthy discussions and=20 > modifications as we move along. >=20 > Does this sound like a good plan or do you guys rather prefer one big=20 > patch ? >=20 > Thanx, > Matthias I like your plan. It is easier to review smaller patches that deal with = specific parts of the overall feature, than it is to try to wrap your head = around one big patch. I would suggest that you go with the smaller = patches. Brad |