Thread: [Gambas-user] Code Reviews
Brought to you by:
gambas
Menu
▾
▴
gambas-user
|
From: Sebastian K. <se...@gm...> - 2012-08-29 04:00:05
|
Okey, i will try to follow this line: What-> Why -> How What?? I will be short; I created a website on google appengine for code reviews [0] It allows you to publish any patch, either of a few lines or a monstrous multi-file spaghetti. But the main feature is that it allows other people to *comment* on single lines of that code, or (re*n)publish that same patch with new changes and comments. The reason for this is evident if you have been following the the activity on the mailing list regarding the gb.net.pop3 component (and obviously, a large amount of other threads about bugs, quick fixes, etc). Pasting code on the list is effective(?), but, how can other users provide feedback? There is everything from inline comments to large -------->, which sometimes are overlooked. Regrettably, neither Sourceforge nor ViewVC provide code comments (like launchpad or google code does) The how is extremely simple. Go to the website, (login with a google account), click *Create Issue*, write a title and upload the patch. This is as easy as "svn diff > patch". It is integrated to the svn repository, so if you upload a patch of a file (in the correct way), the full diff can be viewed online side-by-side or only the changed lines. To share an issue (collection/series of diff files) just copy and paste the url in the list. For a detailed instructions manual, please visit this page [1] I added 2 really simple examples so you can see how it works. <b>Please feel free to play</b>. Code snippets can also be added, so others can improve them (then they can be added to trunk or the wiki snippets page) * Consider this as an experiment, it can either work or not. i really hope it does, bit it's okey if it doesn't [0] https://gambas-svn.appspot.com/ [1] http://code.google.com/p/rietveld/wiki/CodeReviewHelp |
|
From: Benoît M. <ga...@us...> - 2012-08-29 10:52:21
|
Le 29/08/2012 05:59, Sebastian Kulesz a écrit : > Okey, i will try to follow this line: What-> Why -> How > > What?? I will be short; I created a website on google appengine for > code reviews [0] It allows you to publish any patch, either of a few > lines or a monstrous multi-file spaghetti. But the main feature is > that it allows other people to *comment* on single lines of that code, > or (re*n)publish that same patch with new changes and comments. > > The reason for this is evident if you have been following the the > activity on the mailing list regarding the gb.net.pop3 component (and > obviously, a large amount of other threads about bugs, quick fixes, > etc). Pasting code on the list is effective(?), but, how can other > users provide feedback? There is everything from inline comments to > large -------->, which sometimes are overlooked. > > Regrettably, neither Sourceforge nor ViewVC provide code comments > (like launchpad or google code does) > > The how is extremely simple. Go to the website, (login with a google > account), click *Create Issue*, write a title and upload the patch. > This is as easy as "svn diff > patch". > It is integrated to the svn repository, so if you upload a patch of a > file (in the correct way), the full diff can be viewed online > side-by-side or only the changed lines. To share an issue > (collection/series of diff files) just copy and paste the url in the > list. For a detailed instructions manual, please visit this page [1] > > I added 2 really simple examples so you can see how it works. > <b>Please feel free to play</b>. Code snippets can also be added, so > others can improve them (then they can be added to trunk or the wiki > snippets page) > > * Consider this as an experiment, it can either work or not. i really > hope it does, bit it's okey if it doesn't > > > [0] https://gambas-svn.appspot.com/ > > [1] http://code.google.com/p/rietveld/wiki/CodeReviewHelp > This usually should be linked with an issue in the Google tracker, but I don't know if it is possible. Regards, -- Benoît Minisini |
|
From: Tobias B. <ta...@gm...> - 2012-08-29 11:10:42
|
On Wed, 29 Aug 2012, Sebastian Kulesz wrote: > Okey, i will try to follow this line: What-> Why -> How > > What?? I will be short; I created a website on google appengine for > code reviews [0] It allows you to publish any patch, either of a few > lines or a monstrous multi-file spaghetti. But the main feature is > that it allows other people to *comment* on single lines of that code, > or (re*n)publish that same patch with new changes and comments. > > The reason for this is evident if you have been following the the > activity on the mailing list regarding the gb.net.pop3 component (and > obviously, a large amount of other threads about bugs, quick fixes, > etc). Pasting code on the list is effective(?), but, how can other > users provide feedback? There is everything from inline comments to > large -------->, which sometimes are overlooked. > Maybe I'm too young to be conservative, but isn't sending patches and discussion just what the gambas-devel mailing list is for? User comments go to gambas-user. My mail programs perform well; why bring a second tool in? I can't see how it could make things better. > Regrettably, neither Sourceforge nor ViewVC provide code comments > (like launchpad or google code does) > IMHO, if something must change, I'd prefer git over svn where the situation of branch/work/patch/merge is wonderful... which is: way better than svn. > The how is extremely simple. Go to the website, (login with a google > account), click *Create Issue*, write a title and upload the patch. > This is as easy as "svn diff > patch". > It is integrated to the svn repository, so if you upload a patch of a > file (in the correct way), the full diff can be viewed online > side-by-side or only the changed lines. To share an issue > (collection/series of diff files) just copy and paste the url in the > list. For a detailed instructions manual, please visit this page [1] > Will I be able to reasonably use that platform without a browser? I don't like to have my (not javascript-able) browser open all the time and websites aren't "tools" in the sense that I could work with them efficiently. That is just my two cents. To whom it pleases, I'll do the Benoît and say, "Why not?". If someone has something to say about the code I feel responsible for, I would really appreciate them doing it via mail. > I added 2 really simple examples so you can see how it works. > <b>Please feel free to play</b>. Code snippets can also be added, so > others can improve them (then they can be added to trunk or the wiki > snippets page) > > * Consider this as an experiment, it can either work or not. i really > hope it does, bit it's okey if it doesn't > > > [0] https://gambas-svn.appspot.com/ > > [1] http://code.google.com/p/rietveld/wiki/CodeReviewHelp Regards, Tobi |
|
From: Sebastian K. <se...@gm...> - 2012-08-29 21:01:26
|
On Wed, Aug 29, 2012 at 8:09 AM, Tobias Boege <ta...@gm...> wrote: > On Wed, 29 Aug 2012, Sebastian Kulesz wrote: >> Okey, i will try to follow this line: What-> Why -> How >> >> What?? I will be short; I created a website on google appengine for >> code reviews [0] It allows you to publish any patch, either of a few >> lines or a monstrous multi-file spaghetti. But the main feature is >> that it allows other people to *comment* on single lines of that code, >> or (re*n)publish that same patch with new changes and comments. >> >> The reason for this is evident if you have been following the the >> activity on the mailing list regarding the gb.net.pop3 component (and >> obviously, a large amount of other threads about bugs, quick fixes, >> etc). Pasting code on the list is effective(?), but, how can other >> users provide feedback? There is everything from inline comments to >> large -------->, which sometimes are overlooked. >> > > Maybe I'm too young to be conservative, but isn't sending patches and > discussion just what the gambas-devel mailing list is for? User comments go > to gambas-user. My mail programs perform well; why bring a second tool in? > I can't see how it could make things better. > >> Regrettably, neither Sourceforge nor ViewVC provide code comments >> (like launchpad or google code does) >> > > IMHO, if something must change, I'd prefer git over svn where the situation > of branch/work/patch/merge is wonderful... which is: way better than svn. > >> The how is extremely simple. Go to the website, (login with a google >> account), click *Create Issue*, write a title and upload the patch. >> This is as easy as "svn diff > patch". >> It is integrated to the svn repository, so if you upload a patch of a >> file (in the correct way), the full diff can be viewed online >> side-by-side or only the changed lines. To share an issue >> (collection/series of diff files) just copy and paste the url in the >> list. For a detailed instructions manual, please visit this page [1] >> > > Will I be able to reasonably use that platform without a browser? I don't > like to have my (not javascript-able) browser open all the time and websites > aren't "tools" in the sense that I could work with them efficiently. > That is just my two cents. To whom it pleases, I'll do the Benoīt and say, > "Why not?". > > If someone has something to say about the code I feel responsible for, > I would really appreciate them doing it via mail. > >> I added 2 really simple examples so you can see how it works. >> <b>Please feel free to play</b>. Code snippets can also be added, so >> others can improve them (then they can be added to trunk or the wiki >> snippets page) >> >> * Consider this as an experiment, it can either work or not. i really >> hope it does, bit it's okey if it doesn't >> >> >> [0] https://gambas-svn.appspot.com/ >> >> [1] http://code.google.com/p/rietveld/wiki/CodeReviewHelp > > Regards, > Tobi > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Gambas-user mailing list > Gam...@li... > https://lists.sourceforge.net/lists/listinfo/gambas-user > Indeed *git* is what is needed. Branching/merging capabilities for gambas is a must, but that implies moving the whole tree to a new VCS, and it's not too practical, needless to say it can be a really tedious job. In the meantime, i thought something like Rietveld would really help as a collaborative tool. Here are a few threads that would really benefit from this tool, just as an example: http://old.nabble.com/Store-GB_VARIANT-in-memory-td34286343.html http://old.nabble.com/_compare%28%29-Type-mismatch%3A-wanted-Date%2C-Number-or-String-td34235764.html http://old.nabble.com/Convert-string-to-integer-with-arbitrary-base-td33177283.html I'm not saying "Hey, if you want to post code to the mailing list, then use this." I'm just making it available. In the end, its your choice to use it or not. Thanks! |
|
From: Emil L. <emi...@gm...> - 2012-08-29 21:35:56
|
2012/8/29 Tobias Boege <ta...@gm...> > > Maybe I'm too young to be conservative, but isn't sending patches and > discussion just what the gambas-devel mailing list is for? User comments go > to gambas-user. My mail programs perform well; why bring a second tool in? > I can't see how it could make things better. > > Well.. Mailing lists are not the best platform to handle code reviews. No structure, only a bunch of messages. I think it's nice with inline comments, side-by-side diffs etc. Also that patches are not submitted until the discussions are done. In svn you first submit a patch, five minutes later the committer finds a bug but it takes a day to fix, so the svn trunk version is "broken" for a day. If you haven't, look how some of the open source projects at Google are code-reviewed. Golang for example. /Emil |
|
From: Tobias B. <ta...@gm...> - 2012-08-29 22:56:01
|
On Wed, 29 Aug 2012, Emil Lenngren wrote: > 2012/8/29 Tobias Boege <ta...@gm...> > > > > > Maybe I'm too young to be conservative, but isn't sending patches and > > discussion just what the gambas-devel mailing list is for? User comments go > > to gambas-user. My mail programs perform well; why bring a second tool in? > > I can't see how it could make things better. > > > > > Well.. Mailing lists are not the best platform to handle code reviews. No > structure, only a bunch of messages. > I think it's nice with inline comments, side-by-side diffs etc. Also that > patches are not submitted until the discussions are done. In svn you first > submit a patch, five minutes later the committer finds a bug but it takes a > day to fix, so the svn trunk version is "broken" for a day. > If you haven't, look how some of the open source projects at Google are > code-reviewed. Golang for example. > > /Emil Yes, I strongly agree that changes should be reviewed first. And you are right in that mailing lists are not the most convenient and a not the least fancy way to accomplish that but the least common denominator. And in my opinion a rather pretty one: a) Grouping messages into threads is enough structure for my feeling. b) Sent patches can be commented mail-inline, diff'd the way you like, etc.. Of course, this codereview tool cooks everything ready for you... AFAICS, "The golang-dev mailing list is for discussing and reviewing code for the Go project.", they, too, send patches inline (though, some link to this appspot site, maybe for larger patchsets) and discuss via mail? Being able to have multiple branches which are freely mergable from and to other developers would be the way I would go in this regard. It would be rather helpful if not each and every action on the repository's metadata would immediately go through the network into the main repository... But I understand that git may be difficult to switch to or may not be appreciated at all - whatever. I don't want to reject the idea of using this codereview tool and here my constructive questions: What if someone spots a bug in some of my code and I don't even visit that site? How could I participate without using a browser? I.e.: Can a pipe to a mailing list be established from the codereview tool? Sorry, it's late already and I only roughly overlooked Sebastian's manual link. Regards, Tobi |
|
From: Sebastian K. <se...@gm...> - 2012-08-29 23:43:47
|
On Wed, Aug 29, 2012 at 7:55 PM, Tobias Boege <ta...@gm...> wrote: > On Wed, 29 Aug 2012, Emil Lenngren wrote: >> 2012/8/29 Tobias Boege <ta...@gm...> >> >> > >> > Maybe I'm too young to be conservative, but isn't sending patches and >> > discussion just what the gambas-devel mailing list is for? User comments go >> > to gambas-user. My mail programs perform well; why bring a second tool in? >> > I can't see how it could make things better. >> > >> > >> Well.. Mailing lists are not the best platform to handle code reviews. No >> structure, only a bunch of messages. >> I think it's nice with inline comments, side-by-side diffs etc. Also that >> patches are not submitted until the discussions are done. In svn you first >> submit a patch, five minutes later the committer finds a bug but it takes a >> day to fix, so the svn trunk version is "broken" for a day. >> If you haven't, look how some of the open source projects at Google are >> code-reviewed. Golang for example. >> >> /Emil > > Yes, I strongly agree that changes should be reviewed first. > > And you are right in that mailing lists are not the most convenient and a > not the least fancy way to accomplish that but the least common denominator. > And in my opinion a rather pretty one: > a) Grouping messages into threads is enough structure for my feeling. > b) Sent patches can be commented mail-inline, diff'd the way you like, etc.. > Of course, this codereview tool cooks everything ready for you... > > AFAICS, "The golang-dev mailing list is for discussing and reviewing code > for the Go project.", they, too, send patches inline (though, some link to > this appspot site, maybe for larger patchsets) and discuss via mail? > > Being able to have multiple branches which are freely mergable from and to > other developers would be the way I would go in this regard. It would be > rather helpful if not each and every action on the repository's metadata > would immediately go through the network into the main repository... But I > understand that git may be difficult to switch to or may not be appreciated > at all - whatever. > > I don't want to reject the idea of using this codereview tool and here my > constructive questions: What if someone spots a bug in some of my code and I > don't even visit that site? How could I participate without using a browser? > I.e.: Can a pipe to a mailing list be established from the codereview tool? > Sorry, it's late already and I only roughly overlooked Sebastian's manual > link. > > Regards, > Tobi > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Gambas-user mailing list > Gam...@li... > https://lists.sourceforge.net/lists/listinfo/gambas-user Well, this tool integrates pretty well with email. If you upload a piece of code, and somebody uploads a fix for a bug, you will get a mail including the content of that patch. You can also be appointed by another submitter as a reviewer or a interested party on a patch. Benoît, would you even consider moving gambas to a distributed VCS or is that out of the question? There are tools available that can replicate the current svn structure, including tags and svn-branches. *Using Google code would also integrate with its bug tracker. |
|
From: Benoît M. <ga...@us...> - 2012-08-30 01:19:13
|
Le 30/08/2012 01:43, Sebastian Kulesz a écrit : > > Well, this tool integrates pretty well with email. If you upload a > piece of code, and somebody uploads a fix for a bug, you will get a > mail including the content of that patch. You can also be appointed by > another submitter as a reviewer or a interested party on a patch. > > Benoît, would you even consider moving gambas to a distributed VCS or > is that out of the question? There are tools available that can > replicate the current svn structure, including tags and svn-branches. Now? I'm not against moving to git, but I don't have the time to deal with that now (I have to learn it). At the moment I am more worried about gb.net.pop3 and gb.adt and gb.option. Let's clean them so that I can release Gambas 3.3. Otherwise, for your own needs, you don't have to work on /trunk. You can create your own branches if you need, and merge them later in /trunk. For example in something like /branches/sebikul/trunk. As for using more tools, or other tools, I'm just worrying about the dependencies of the project: Sourceforge, Google for the issue tracker, and Rob's server for the documentation at the moment. I'd like to keep these dependencies minimial as much as possible. Regards, -- Benoît Minisini |
|
From: Tobias B. <ta...@gm...> - 2012-08-30 00:00:25
|
> > I don't want to reject the idea of using this codereview tool and here my > > constructive questions: What if someone spots a bug in some of my code and I > > don't even visit that site? How could I participate without using a browser? > > I.e.: Can a pipe to a mailing list be established from the codereview tool? > > Sorry, it's late already and I only roughly overlooked Sebastian's manual > > link. > > > > Regards, > > Tobi > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Gambas-user mailing list > > Gam...@li... > > https://lists.sourceforge.net/lists/listinfo/gambas-user > > Well, this tool integrates pretty well with email. If you upload a > piece of code, and somebody uploads a fix for a bug, you will get a > mail including the content of that patch. You can also be appointed by > another submitter as a reviewer or a interested party on a patch. > > Beno?t, would you even consider moving gambas to a distributed VCS or > is that out of the question? There are tools available that can > replicate the current svn structure, including tags and svn-branches. > > *Using Google code would also integrate with its bug tracker. So, if it can be made transparent over a mailing list (and we can get such tags in the Subject: lines to allow sorting mail) I'll drop any objection. Regards, Tobi |
|
From: Sebastian K. <se...@gm...> - 2012-08-30 01:02:30
|
On Wed, Aug 29, 2012 at 8:59 PM, Tobias Boege <ta...@gm...> wrote: >> > I don't want to reject the idea of using this codereview tool and here my >> > constructive questions: What if someone spots a bug in some of my code and I >> > don't even visit that site? How could I participate without using a browser? >> > I.e.: Can a pipe to a mailing list be established from the codereview tool? >> > Sorry, it's late already and I only roughly overlooked Sebastian's manual >> > link. >> > >> > Regards, >> > Tobi >> > >> > ------------------------------------------------------------------------------ >> > Live Security Virtual Conference >> > Exclusive live event will cover all the ways today's security and >> > threat landscape has changed and how IT managers can respond. Discussions >> > will include endpoint security, mobile security and the latest in malware >> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> > _______________________________________________ >> > Gambas-user mailing list >> > Gam...@li... >> > https://lists.sourceforge.net/lists/listinfo/gambas-user >> >> Well, this tool integrates pretty well with email. If you upload a >> piece of code, and somebody uploads a fix for a bug, you will get a >> mail including the content of that patch. You can also be appointed by >> another submitter as a reviewer or a interested party on a patch. >> >> Beno?t, would you even consider moving gambas to a distributed VCS or >> is that out of the question? There are tools available that can >> replicate the current svn structure, including tags and svn-branches. >> >> *Using Google code would also integrate with its bug tracker. > > So, if it can be made transparent over a mailing list (and we can get such > tags in the Subject: lines to allow sorting mail) I'll drop any objection. > > Regards, > Tobi > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Gambas-user mailing list > Gam...@li... > https://lists.sourceforge.net/lists/listinfo/gambas-user It still needs some real testing, but email works. if you send a mail to re...@ga... with an issue id in the subject in the form of "(issue ##)" including the parenthesis, the comment is properly added. I read the source code; there is no support for adding a patch set that way and the issue id strictly needs to be in that format. It also has problems when answering directly to the mails it sent, but i'm testing a custom fix for that (i will push the update when i finish the fix, to use it now you need to create a new email), but if you don't want to use the website, Rietveld provides a command line tool [0] Please let me know if you have any more questions. [0] http://code.google.com/p/rietveld/wiki/UploadPyUsage * You will need to download it from our website as it is already customized. Head to "Create issue" and click "Download upload.py" |
|
From: Tobias B. <ta...@gm...> - 2012-08-30 01:12:47
|
On Wed, 29 Aug 2012, Sebastian Kulesz wrote: > On Wed, Aug 29, 2012 at 8:59 PM, Tobias Boege <ta...@gm...> wrote: > >> > I don't want to reject the idea of using this codereview tool and here my > >> > constructive questions: What if someone spots a bug in some of my code and I > >> > don't even visit that site? How could I participate without using a browser? > >> > I.e.: Can a pipe to a mailing list be established from the codereview tool? > >> > Sorry, it's late already and I only roughly overlooked Sebastian's manual > >> > link. > >> > > >> > Regards, > >> > Tobi > >> > > >> > ------------------------------------------------------------------------------ > >> > Live Security Virtual Conference > >> > Exclusive live event will cover all the ways today's security and > >> > threat landscape has changed and how IT managers can respond. Discussions > >> > will include endpoint security, mobile security and the latest in malware > >> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> > _______________________________________________ > >> > Gambas-user mailing list > >> > Gam...@li... > >> > https://lists.sourceforge.net/lists/listinfo/gambas-user > >> > >> Well, this tool integrates pretty well with email. If you upload a > >> piece of code, and somebody uploads a fix for a bug, you will get a > >> mail including the content of that patch. You can also be appointed by > >> another submitter as a reviewer or a interested party on a patch. > >> > >> Beno?t, would you even consider moving gambas to a distributed VCS or > >> is that out of the question? There are tools available that can > >> replicate the current svn structure, including tags and svn-branches. > >> > >> *Using Google code would also integrate with its bug tracker. > > > > So, if it can be made transparent over a mailing list (and we can get such > > tags in the Subject: lines to allow sorting mail) I'll drop any objection. > > > > Regards, > > Tobi > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Gambas-user mailing list > > Gam...@li... > > https://lists.sourceforge.net/lists/listinfo/gambas-user > > It still needs some real testing, but email works. if you send a mail > to re...@ga... with an issue id in the subject in > the form of "(issue ##)" including the parenthesis, the comment is > properly added. I read the source code; there is no support for adding > a patch set that way and the issue id strictly needs to be in that > format. It also has problems when answering directly to the mails it > sent, but i'm testing a custom fix for that (i will push the update > when i finish the fix, to use it now you need to create a new email), > but if you don't want to use the website, Rietveld provides a command > line tool [0] > > Please let me know if you have any more questions. > > [0] http://code.google.com/p/rietveld/wiki/UploadPyUsage > * You will need to download it from our website as it is already > customized. Head to "Create issue" and click "Download upload.py" > Thank you for your efforts. I will look at it tomorrow. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X