Re: [Fwbuilder-discussion] fwbuilder 4.1.1 problem on embedded system
Brought to you by:
mikehorn
From: Vadim K. <va...@vk...> - 2010-09-22 21:20:31
|
On Wed, Sep 22, 2010 at 2:04 PM, Erich Titl <eri...@th...> wrote: > Hi Vadim > > on 22.09.2010 16:31, Vadim Kurland wrote: >> Hi Erich, >> >> this is basically what I was going to do, except geenrated script >> needs modprobe in two cases: if user wants to load modules and also if >> user wants to configure vlan or bonding interfaces. In the latter case >> script tries to load modules 8021q and bonding. Also, variable >> {{load_modules}} is not set in this configlet, that needs to be added >> to the code. > > Actually load_modules appears to be set, I changed the configlet and got > exactly what I wanted. > > Now of course if one wanted to cover all the possibilities it might be > more difficult. At first I did not recognize the fact that the new rules > were not loaded, because the generated script was very small and I did > not care much about the return value, and then I am running some code on > the command line after the firewall script, this runs unconditionally > and returns a reasonable value. I probably have to check the return > value of the firewall script and decide then. Maybe my method is botched. > > ssh will return a good value if the connection was successful, I > _believe_ regardless of the script return value, so it is difficult to > check from the installer. Maybe some tagged message could be embedded in > the generated script which could be analyzed by the installer. on unix ssh terminates with the return value of the last command, as expected, and fwbuilder checks it to mark install session as "success" or "failure". On Windows however plink seems to always return with "good" return value so this does not work there. I have fixed this in one of the latest builds. Installer watches script output anyway, looking for one of the standard error messages and so the latest build marks install as "failure" if it saw any error message even though ssh returns "ok". --vk |