Re: [fuse-devel] [PATCH] Document readdir()/readdirplus() effects on lookup count

[Nikolaus R. <Nik...@ra...>]

*ping*


> Miklos, how about this patch?
>
>
> diff --git a/include/fuse_lowlevel.h b/include/fuse_lowlevel.h
> --- a/include/fuse_lowlevel.h
> +++ b/include/fuse_lowlevel.h
> @@ -600,6 +600,9 @@
>  	 *
>  	 * fi->fh will contain the value set by the opendir method, or
>  	 * will be undefined if the opendir method didn't set any value.
> +         *
> +	 * Returning a directory entry from readdir() does not affect
> +	 * its lookup count. 
>  	 *
>  	 * Valid replies:
>  	 *   fuse_reply_buf
> @@ -1026,6 +1029,10 @@
>  	 *
>  	 * fi->fh will contain the value set by the opendir method, or
>  	 * will be undefined if the opendir method didn't set any value.
> +         *
> +	 * In contrast to readdir() (which does not affect the lookup
> +	 * counts), the lookup count of every entry returned by
> +	 * readdirplus() is increased by one.
>  	 *
>  	 * Introduced in version 3.0
>  	 *
> @@ -1176,6 +1183,11 @@
>   * Possible requests:
>   *   read, readdir, getxattr, listxattr
>   *
> + * Side effects:
> + *   when used to return data from a readdirplus() (but not readdir())
> + *   call, increments the lookup count of each returned entry by one
> + *   on success.
> + *
>   * @param req request handle
>   * @param bufv buffer vector
>   * @param flags flags controlling the copy
>
>
> Best,
>
>    -Nikolaus
>
> -- 
>  »Time flies like an arrow, fruit flies like a Banana.«
>
>   PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and 
> their applications. This 200-page book is written by three acclaimed 
> leaders in the field. The early access version is available now. 
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> fuse-devel mailing list
> fus...@li...
> https://lists.sourceforge.net/lists/listinfo/fuse-devel


   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C