Re: [fuse-devel] [RFC PATCH v2, part4 09/39] mm: use totalram_pages instead of num_physpages at runtime

[Sergei S. <ser...@co...>]

Hello.

On 24-03-2013 11:24, Jiang Liu wrote:

> The global variable num_physpages is scheduled to be removed, so use
> totalram_pages instead of num_physpages at runtime.

> Signed-off-by: Jiang Liu <jia...@hu...>
> Cc: Miklos Szeredi <mi...@sz...>
> Cc: "David S. Miller" <da...@da...>
> Cc: Alexey Kuznetsov <ku...@ms...>
> Cc: James Morris <jm...@na...>
> Cc: Hideaki YOSHIFUJI <yos...@li...>
> Cc: Patrick McHardy <ka...@tr...>
> Cc: fus...@li...
> Cc: lin...@vg...
> Cc: ne...@vg...
[...]

> diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
> index 4750d2b..94a99a1 100644
> --- a/net/ipv4/inet_fragment.c
> +++ b/net/ipv4/inet_fragment.c
> @@ -60,7 +60,7 @@ void inet_frags_init(struct inet_frags *f)
>
>   	rwlock_init(&f->lock);
>
> -	f->rnd = (u32) ((num_physpages ^ (num_physpages>>7)) ^
> +	f->rnd = (u32) ((totalram_pages ^ (totalram_pages>>7)) ^

    Wouldn't hurt to add spaces around >> for consistency's sake.

>   				   (jiffies ^ (jiffies >> 6)));
>
>   	setup_timer(&f->secret_timer, inet_frag_secret_rebuild,

WBR, Sergei