From: Feng S. <ste...@gm...> - 2013-01-22 16:06:20
|
Hi Miklos, Yes, I think it will be nice to keep all xattrs opaque to FUSE kernel because this will keep a clean and unitifed kernel/user space interface, but it will still be necessary to invalid the inode by fuse_invalidate_attr() after setxattr. This will make the kernel reload the "i_mode" to the user space ACL implementations possible. On Tue, Jan 22, 2013 at 9:50 PM, Miklos Szeredi <mi...@sz...> wrote: > On Tue, Jan 22, 2013 at 3:23 AM, Nikolaus Rath <Nik...@ra...> wrote: >> Yes, fuse does not reivalidate the file mode after setxattr() calls (at >> least with Kernel 3.2 and fuse 2.9). >> >> I'll patch up some handler code in my file system based on >> posix_acl_equiv_mode (thanks for the link!) and an explicit >> fuse_lowlevel_notify_inval_inode call. >> >> >> I agree that FUSE should call posix_acl_equiv_mode(), followed by >> setattr() and (only if necessary) setxattr(). > > FUSE kernel code doesn't support POSIX ACL's at all presently. > > Adding ACL support would make sense, and with that the reported bug > would be fixed. > > With ACL support turned off (as presently) then I think the current > behavior is fine: the kernel should just pass unmodified xattrs to > userspace. > > Thanks, > Miklos > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > fuse-devel mailing list > fus...@li... > https://lists.sourceforge.net/lists/listinfo/fuse-devel -- Feng Shuo Tel: (86)10-59851155-2116 Fax: (86)10-59851155-2008 Tianjin Zhongke Blue Whale Information Technologies Co., Ltd 10th Floor, Tower A, The GATE building, No. 19 Zhong-guan-cun Avenue Haidian District, Beijing, China Postcode 100080 |