Re: [fuse-devel] _FILE_OFFSET_BITS=64 should to be enforced on 64bit architectures

[Alon Bar-L. <alo...@gm...>]

On 1/22/08, Miklos Szeredi <mi...@sz...> wrote:
> > >
> > > If you have a concrete example, wher adding _FILE_OFFSET_BITS=64
> > > actually breaks the build, then I'm open to suggestions for fixing it.
> > >
> > > "Perfect is the enemy of good."
> >
> > It just that the autoconf may undef it if it is not required... No
> > perfect here...
>
> OK, I'm beginning to understand what the problem is:
>
>   - project uses AC_SYS_LARGEFILE in configure.ac
>   - only tests on 32bit, fuse works fine, because _FILE_OFFSET_BITS=64
>     is defined
>   - breaks on 64bit, because _FILE_OFFSET_BITS=64 is not defined
>
> The right solution for that, I think, is to use
>
>   PKG_CHECK_MODULES(FOO, [fuse])
>
> in addition to (or instead of) AC_SYS_LARGEFILE, which unconditionally
> defines _FILE_OFFSET_BITS=64, as well as correctly setting up the
> include and library paths for fuse.
>
> Hmm?

No... I believe correct settings would be for fuse not to check
_FILE_OFFSET_BITS on 64bit platform...

Alon.