Re: [FreeWRL] UI frontends - was: FreeWRL 1.22.8 -- Linux packaging

[Michel B. <mic...@fr...>]

Dave Joubert <dav...@go...> - Mon, 3 May 2010 18:40:33
+0100

>Hi,
>
>As part of estimating how big a job it would be to port to Qt, I
>looked at the code wrapped in ifdef TARGET_MOTIF.
>
>I found about 250-300 lines distributed across 6 files, and mentally
>it looked possible to possible to turn them into 2 files. In theory,
>this could be a good thing anyway, because it would automatically
>seperate the code into 2 sections, ie window dependent and windowing
>independent.
>
>I then looked at the other TARGET_ sections, to help in the estimate.
>
>However, this raised some questions:
>
>The IPHONE defines: should they really be TARGET_IPHONE defines instead ?
>(The Mac OS ones are separated into AQUA and TARGET_AQUA)
>

You right :) !

>The WIN32 defines: saw _WIN32 and WIN32
>My grep also colourises, which makes it difficult to distinguish
>between (_WIN32 ) ( WIN32 ) and (WIN32)
>
>./src/lib/main/MainLoop.c:242:#if !defined(_WIN32)
>./src/lib/main/MainLoop.c:361:#if !defined( AQUA ) && !defined( WIN32 )

Just discussed with Doug about that.

Windows port should use most TARGET_WIN32 in a few weeks when we'll be
finished with this rewriting. All code specific to the platform but
that can compile with gcc. Yes gcc! A cross-compile environment is
being built ;)...

Specific code that makes MS compiler cry will be wrapped by #ifdef
_MSC_VER.

To sum up we should only have TARGET_<platform> and that's all (at a
very few exception).


Michel