[Freevo-devel] Re: Bug in freevo_runtime

[Dirk M. <dm...@tz...>]

Krister Lagerstrom wrote:
> Dirk Meyer wrote:
>  > Krister Lagerstrom wrote:
>
>  >> Dirk Meyer wrote: Great. If I get the time I can try and take a
>  >> look at it, but I can't promise when that will be. In the meantime
>  >> your fix will hopefully be good enough, just test with the runtime
>  >> once in a while (I always run with it).
>  >
>  > OK, this must be fixed before the next release.
>
> I'll see if I can get it to work, but the ui.py is pretty advanced so
> it might not happen before the next release as long as Freevo works anyway.

OK

>
>  > OK, there is a difference. My installation reports for TV in main
>  > menu width=69 and height=47. Your runtime reports 70 and 37. The
>  > width isn't right but it doesn't matter, but the height is totally
>  > wrong. My version seems to be right since the selection looks ok
>  > without the runtime. BTW, I have SDL_ttf 2.0.5 and _no_ patch from
>  > you installed.
>
> I've included a small screenshot from my system where I've modified the
> main skin and xml code to display the selectionbar in the same size as
> returned by osd.stringsize(). It looks OK to me as far as I can tell,
> the top is higher than the letters, but I think that is what is
> returned by SDL_ttf. The bottom is exactly at the last line of the
> text, which is consistent with my patch to SDL_ttf.

That's the bug. The selection is suppossed to be 8 Pixel larger than
the text. It's coincidence that the bottom of the text is identical
with the bar, it should be 8 Pixels larger.

> The patch I made to SDL_ttf prevents it from crashing in some cases
> since it can draw more lines of pixels than it allocated memory for!
> So I changed the SDL_ttf string size calculation to be the same as
> the actual drawing routine, and made sure that is used for memory
> allocation.

Is there a new version out there? I have no problems with my version
(2.0.5 on this machine). Maybe I will try my current version with your
patch. 

> My point here is that I think my patched version should be the standard
> for the reasons listed above.

OK, and what version of SDL_ttf is included in the runtime lib. Read
another mail from me from today, there is also a unicode problem with
the runtime SDL_ttf.

> It would make it easier to make releases if development is done using
> the Freevo runtime since bugs will be caught earlier then.

Agreed.


Dischi

-- 
"Programming today is a race between software engineers striving to build 
bigger and better idiot-proof programs, and the Universe trying to produce 
bigger and better idiots. So far, the Universe is winning." - Rich Cook