[Freevo-tracker] [ freevo-Bugs-2502039 ] crash when browsing CD

[SourceForge.net <no...@so...>]

Bugs item #2502039, was opened at 2009-01-12 19:12
Message generated for change (Comment added) made by mennucc
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2502039&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.8.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: A C G Mennucc (mennucc)
Assigned to: Nobody/Anonymous (nobody)
Summary: crash when browsing CD

Initial Comment:
hi, as soon as I try to browse into a subdirectory of a CD, freevo crashes with the following tracebacks. a.


Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/freevo/main.py", line 299, in eventhandler
    app.eventhandler(event)
  File "/usr/share/pyshared/freevo/util/benchmark.py", line 91, in origfunc
    return func(*args, **kwargs)
  File "/usr/share/pyshared/freevo/menu.py", line 874, in eventhandler
    self._handle_play_item(menu, event)
  File "/usr/share/pyshared/freevo/util/benchmark.py", line 91, in origfunc
    return func(*args, **kwargs)
  File "/usr/share/pyshared/freevo/menu.py", line 683, in _handle_play_item
    action(arg=arg, menuw=self)
  File "/usr/share/pyshared/freevo/util/benchmark.py", line 91, in origfunc
    return func(*args, **kwargs)
  File "/usr/share/pyshared/freevo/directory.py", line 498, in cwd
    self.check_password_and_build(arg=None, menuw=menuw)
  File "/usr/share/pyshared/freevo/util/benchmark.py", line 91, in origfunc
    return func(*args, **kwargs)
  File "/usr/share/pyshared/freevo/directory.py", line 562, in check_password_and_build
    self.build(arg=arg, menuw=menuw)
  File "/usr/share/pyshared/freevo/util/benchmark.py", line 91, in origfunc
    return func(*args, **kwargs)
  File "/usr/share/pyshared/freevo/directory.py", line 809, in build
    dirwatcher.cwd(menuw, self, item_menu, self.dir)
  File "/usr/share/pyshared/freevo/util/benchmark.py", line 91, in origfunc
    return func(*args, **kwargs)
  File "/usr/share/pyshared/freevo/directory.py", line 1038, in cwd
    self.last_time = vfs.mtime(self.dir)
  File "/usr/share/pyshared/freevo/util/vfs.py", line 131, in mtime
    t = os.stat(name)[ST_MTIME]
OSError: [Errno 2] No such file or directory: '/cdrom/Moderna'
2009-01-12 18:52:37,147 WARNING  fileops.py (407): mounting '/cdrom/Moderna': mount: can't find /cdrom/Moderna in /etc/fstab or /etc/mtab



----------------------------------------------------------------------

>Comment By: A C G Mennucc (mennucc)
Date: 2009-01-12 19:32

Message:
BTW, the lines such as
 2009-01-12 19:19:50,257 WARNING  fileops.py (407): mounting
'/cdrom/Moderna': mount: can't find /cdrom/Moderna in /etc/fstab or
/etc/mtab
tell of another different bug: some part of the code is trying to mount
something that is not a device .. unfortunately there is not a complete
traceback to tell where this is coming from. How do I get a complete
traceback in the log? a.


----------------------------------------------------------------------

Comment By: A C G Mennucc (mennucc)
Date: 2009-01-12 19:30

Message:
I tried this simple patch 

--- directory.py~	2008-11-16 18:51:46.000000000 +0100
+++ directory.py	2009-01-12 19:16:19.000000000 +0100
@@ -806,7 +806,8 @@
 
             menuw.pushmenu(item_menu)
 
-            dirwatcher.cwd(menuw, self, item_menu, self.dir)
+            if not self.media:
+                dirwatcher.cwd(menuw, self, item_menu, self.dir)
             self.menu  = item_menu
             self.menuw = menuw
 
but then freevo crashes with a different traceback ; I attach all
tracebacks Igot so far.

 The general problem AFAICT is that many parts of the code are
mounting/unmounting the cdrom , while some  other part of the code (e.g.
the dirwatcher) try to access the CD at the same time when it is
unmounted... wouldn't it be simpler to just mount the CD once when the user
starts browsing it, and unmount when the user exits from that part of the
directory tree?

 BTW, to access the CD I resort to mounting it as root ... this works .

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2502039&group_id=46652