Re: [Freevo-users] bug in genericitem.py

[vlad <vl...@un...>]

hello, 

with freevo 1.7.4 the ps1 entry from the games menu (see below) didn't work though i
didn't change anything in the conf file. choosing games from the menu
didn't work at all - nothing happened. it seemed that smth wasn't passed right to the commandline. 
then i vimdiffed the genericitem.py files from 1.7.3 and 1.7.4 saw that 
that particular line was commented out. uncommenting it was (for me) the
solution.

vlad

On Tue, Nov 20, 2007 at 11:58:58AM +0100, cen...@la... wrote:
> Hi, i was the initial author of this generic feature. The file given as
> argument is built from the choice you select on the list of games you have
> in the folder. So as far as i see, the current setup you hav should work.
> What is exactly the issue?
> 
> > hi,
> >
> > is there another way to get generic games running?
> > i have this in my config:
> > "
> > GAMES_ITEMS = [
> >                 ('PlayStation One (ePSXe)', '/home/vlad/spiele/cdimages/',
> > ('GENERIC', '/home/vlad/.PersonalBin/epsxe', '-nogui
> > -loadiso', '', [ 'img','bin','iso' ] )),
> >                 ('PlayStation One (pSX)', '/home/vlad/spiele/cdimages/',
> > ('GENERIC', '/home/vlad/.PersonalBin/psx-freevo', '', '',
> > [ 'img','bin','iso','mdf','cdz' ] ))
> >               ]
> > "
> > what do you mean by "a file can be passed as one of the arguments"?
> > smth like: "'-nogui -loadiso *.[img|bin|iso]'"
> >
> > vlad
> >
> > On Tue, Nov 20, 2007 at 06:55:26AM +0100, Duncan Webb wrote:
> >> > hello list,
> >> >
> >> > in /usr/lib/python2.5/site-packages/freevo/games/genericitem.py
> >> > line 73:
> >> > "
> >> > 71        command = ['--prio=%s' % config.GAMES_NICE, cmd]
> >> > 72        command.extend(args.split())
> >> > 73        #command.append(file)
> >> > "
> >> > must be uncommented.
> >>
> >> If this is uncommented then other Linux games don't work. IIRC a file
> >> can
> >> be passed as one of the arguments in the games configuration.
> >>
> >> Duncan

--