From: SourceForge.net <no...@so...> - 2007-01-15 04:27:33
|
Bugs item #1635543, was opened at 2007-01-14 20:27 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface Group: Latest Subversion Status: Open Resolution: None Priority: 3 Private: No Submitted By: Geoff Topping (geoffthemedio) Assigned to: Nobody/Anonymous (nobody) Summary: ColourSelector Appears Off Screen Initial Comment: On the options screen, colour options near the bottom of the FO window can spawn a colour selector window that appears parly off the screen. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 |
From: SourceForge.net <no...@so...> - 2007-02-17 18:01:03
|
Bugs item #1635543, was opened at 2007-01-15 05:27 Message generated for change (Comment added) made by guardian24 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface Group: Latest Subversion Status: Open Resolution: None Priority: 3 Private: No Submitted By: Geoff Topping (geoffthemedio) Assigned to: Nobody/Anonymous (nobody) Summary: ColourSelector Appears Off Screen Initial Comment: On the options screen, colour options near the bottom of the FO window can spawn a colour selector window that appears parly off the screen. ---------------------------------------------------------------------- Comment By: guardian24 (guardian24) Date: 2007-02-17 19:01 Message: Logged In: YES user_id=1536944 Originator: NO It is not a bug, it is a annoyance. :) The color selection window is movable, so it is not a big deal. >From CUIControls.cpp: void ColorSelector::LClick(const GG::Pt& pt, Uint32 keys) { GG::ColorDlg dlg(pt.x, pt.y, ....... ColorDlg's height is 300, so it could be checked against the screen's height. Maybe it could be replaced with something like this: SDL_VideoInfo* vidinfo=SDL_GetVideoInfo(); if ((pt.y+300) > vidinfo->current_h) { GG::ColorDlg dlg(pt.x,current_h-300, ...... } else { GG::ColorDlg dlg(pt.x,pt.y, ....... } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 |
From: SourceForge.net <no...@so...> - 2007-02-17 20:10:16
|
Bugs item #1635543, was opened at 2007-01-15 05:27 Message generated for change (Comment added) made by guardian24 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface Group: Latest Subversion Status: Open Resolution: None Priority: 3 Private: No Submitted By: Geoff Topping (geoffthemedio) Assigned to: Nobody/Anonymous (nobody) Summary: ColourSelector Appears Off Screen Initial Comment: On the options screen, colour options near the bottom of the FO window can spawn a colour selector window that appears parly off the screen. ---------------------------------------------------------------------- Comment By: guardian24 (guardian24) Date: 2007-02-17 21:10 Message: Logged In: YES user_id=1536944 Originator: NO Sorry for the spam, but i forgot to add a 'const' before SDL_VideoInfo*. :( ---------------------------------------------------------------------- Comment By: guardian24 (guardian24) Date: 2007-02-17 19:01 Message: Logged In: YES user_id=1536944 Originator: NO It is not a bug, it is a annoyance. :) The color selection window is movable, so it is not a big deal. >From CUIControls.cpp: void ColorSelector::LClick(const GG::Pt& pt, Uint32 keys) { GG::ColorDlg dlg(pt.x, pt.y, ....... ColorDlg's height is 300, so it could be checked against the screen's height. Maybe it could be replaced with something like this: SDL_VideoInfo* vidinfo=SDL_GetVideoInfo(); if ((pt.y+300) > vidinfo->current_h) { GG::ColorDlg dlg(pt.x,current_h-300, ...... } else { GG::ColorDlg dlg(pt.x,pt.y, ....... } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 |
From: SourceForge.net <no...@so...> - 2007-02-18 03:19:58
|
Bugs item #1635543, was opened at 2007-01-14 20:27 Message generated for change (Comment added) made by geoffthemedio You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface Group: Latest Subversion >Status: Closed >Resolution: Fixed Priority: 3 Private: No Submitted By: Geoff Topping (geoffthemedio) Assigned to: Nobody/Anonymous (nobody) Summary: ColourSelector Appears Off Screen Initial Comment: On the options screen, colour options near the bottom of the FO window can spawn a colour selector window that appears parly off the screen. ---------------------------------------------------------------------- >Comment By: Geoff Topping (geoffthemedio) Date: 2007-02-17 19:19 Message: Logged In: YES user_id=913462 Originator: YES Fixed in SVN. Basic idea suggested is OK, but I used std::min and GG's built-in GUI-info getters, in the manner of: int x = std::min(pt.x, GG::GUI::GetGUI()->AppWidth() - 315); // 315 is width of ColorDlg from GG::ColorDlg:::ColorDlg in void ColorSelector::LClick(const GG::Pt& pt, Uint32 keys) Note that if the FO window is smaller than 315 x 300 pixels, this could lead to the ColorDlg appearing partly off the upper left of the window, but this seems less likely to be a problem in practice. ---------------------------------------------------------------------- Comment By: guardian24 (guardian24) Date: 2007-02-17 12:10 Message: Logged In: YES user_id=1536944 Originator: NO Sorry for the spam, but i forgot to add a 'const' before SDL_VideoInfo*. :( ---------------------------------------------------------------------- Comment By: guardian24 (guardian24) Date: 2007-02-17 10:01 Message: Logged In: YES user_id=1536944 Originator: NO It is not a bug, it is a annoyance. :) The color selection window is movable, so it is not a big deal. >From CUIControls.cpp: void ColorSelector::LClick(const GG::Pt& pt, Uint32 keys) { GG::ColorDlg dlg(pt.x, pt.y, ....... ColorDlg's height is 300, so it could be checked against the screen's height. Maybe it could be replaced with something like this: SDL_VideoInfo* vidinfo=SDL_GetVideoInfo(); if ((pt.y+300) > vidinfo->current_h) { GG::ColorDlg dlg(pt.x,current_h-300, ...... } else { GG::ColorDlg dlg(pt.x,pt.y, ....... } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1635543&group_id=75752 |