Menu

#220 BeansWrapper wrap method does not default to BeanModel

2.3.22
closed-fixed
nobody
5
2015-02-28
2008-08-01
Ianw
No

According to javadoc the wrap method on BeansWrapper should default to generic BeanModel, however it is defaulting to StringModel.

See code snippet from BeansWrapper class:

protected ModelFactory getModelFactory(Class clazz) {
if(Map.class.isAssignableFrom(clazz)) {
return simpleMapWrapper ? SimpleMapModel.FACTORY : MapModel.FACTORY;
}
if(Collection.class.isAssignableFrom(clazz)) {
return CollectionModel.FACTORY;
}
if(Number.class.isAssignableFrom(clazz)) {
return NumberModel.FACTORY;
}
if(Date.class.isAssignableFrom(clazz)) {
return DateModel.FACTORY;
}
if(Boolean.class == clazz) { // Boolean is final
return BOOLEAN_FACTORY;
}
if(ResourceBundle.class.isAssignableFrom(clazz)) {
return ResourceBundleModel.FACTORY;
}
if(Iterator.class.isAssignableFrom(clazz)) {
return ITERATOR_FACTORY;
}
if(Enumeration.class.isAssignableFrom(clazz)) {
return ENUMERATION_FACTORY;
}
if(clazz.isArray()) {
return ArrayModel.FACTORY;
}
return StringModel.FACTORY;
}

Discussion

  • Dániel Dékány

    That's a JavaDoc mistake.

     
  • Dániel Dékány

    • status: open --> open-fixed
    • Group: --> undecided
     
  • Dániel Dékány

    • Group: undecided --> 2.3.22
     
  • Dániel Dékány

    • Status: open-fixed --> closed-fixed
     

Log in to post a comment.