From: John F. F. <joh...@cy...> - 2012-03-11 02:18:31
|
I'll second that. - John F. On 3/10/2012 8:46 AM, John Tsiombikas wrote: > On Sat, Mar 10, 2012 at 11:34:53AM +0800, Diederick C. Niehorster wrote: > >> Dear all, >> >> I noticed that there is a lot of code duplication in >> freeglut_geometry. It'd be easily cleaned up. >> >> .... >> >> void FGAPIENTRY glutWireTetrahedron( void ) >> { >> FREEGLUT_EXIT_IF_NOT_INITIALISED ( "glutWireTetrahedron" ); >> >> fghTetrahedron( GL_LINE_LOOP ); >> } >> void FGAPIENTRY glutSolidTetrahedron( void ) >> { >> FREEGLUT_EXIT_IF_NOT_INITIALISED ( "glutSolidTetrahedron" ); >> >> fghTetrahedron( GL_TRIANGLES ); >> } >> >> Shall I go ahead and do that for this and the other object in there? >> I'll put the body of the solid and wire version through a diff tool >> for each first to make sure they really are identical. >> >> This allows me to do a bit of structuring in the file too. >> > Very nice, go ahead. Actually I think this kind of restructuring is > minor and safe enough that falls under the just do it without asking > category. > > |