From: gerard r. <gh...@gm...> - 2008-06-05 14:16:14
|
On lun 2 juin 2008, Tim Moore wrote: > Update of > /var/cvs/FlightGear-0.9/source/src/FDM/JSBSim/models/flight_control In > directory baron:/tmp/cvs-serv2999/src/FDM/JSBSim/models/flight_control > > Modified Files: > FGActuator.cpp FGFCSComponent.h > Log Message: > Clean up header file use of iostream and "using" declarations > > Replace include <iostream> with istream, ostream and/or iosfwd as > appropriate. > > Remove using namespace std and using std::foo from header files. Does this will be compatible with actual JSBSim development ? -- Gérard http://pagesperso-orange.fr/GRTux/ "J'ai décidé d'être heureux parce que c'est bon pour la santé. Voltaire " |
From: Tim M. <ti...@re...> - 2008-06-05 20:38:04
|
On Thu, 5 Jun 2008 17:22:33 +0200 Melchior FRANZ <mf...@ao...> wrote: > * gerard robin -- Thursday 05 June 2008: > > Does this will be compatible with actual JSBSim development ? > > No, it will get overwritten with the next JSBSim update. There's > a reason why commits to externally maintained parts of fgfs (nasal, > jsbsim) used to be taboo, just like commits to parts which are > strictly maintained by a single person or small group (YASim). > (UIUC may no longer belong to either group, as it seems to be > unmaintained.) > > The right thing would have been to ask the responsible maintainers, > to have them make the changes in their repositories, and then to > forward port that. But then again, times change, and maybe all that > is no longer true ... > > m. I never got the memo that large parts of the tree were off limits. I agree that a substantive change should be vetted by "owners" first, but I don't really see the point for fairly cosmetic changes. On the other hand, why is JSBSim in our CVS at all if new versions are brought in in this way? Tim |
From: Melchior F. <mf...@ao...> - 2008-06-05 21:11:02
|
* Tim Moore -- Thursday 05 June 2008: > I never got the memo that large parts of the tree were off limits. In the old days one didn't need memos for that. One had to be around long enough before one even got CVS access. Enough time to learn the rules. Not your fault, of course, that this has changed now. > I don't really see the point for fairly cosmetic changes. The point is: what you consider an improvement might not be seen as such by the code *owner*. And the owner's wish usually trumps a contributor's. > On the other hand, why is JSBSim in our CVS at all if new versions are > brought in in this way? What way would you prefer? Some projects are on other servers, and CVS has no way to import them directly. They need to be copied in. This hasn't been a problem in the past. You just have to know that making changes in those copies is totally pointless. m. |
From: gerard r. <gh...@gm...> - 2008-06-06 00:55:20
|
On jeu 5 juin 2008, Melchior FRANZ wrote: > > On the other hand, why is JSBSim in our CVS at all if new versions are > > brought in in this way? > > What way would you prefer? Some projects are on other servers, and > CVS has no way to import them directly. They need to be copied in. > This hasn't been a problem in the past. You just have to know that > making changes in those copies is totally pointless. > > m. And i fear, that "process" will increase the distance between JSBSim and FG, and probably going to a JSBSim use in a stand alone way ONLY, working with FG through an external communication. Today the users who are using JSBSim with FG could include the most recent original code of it into FG, in to get a running updated FG+JSBSim (last version) What will happen now with that update from Tim which is not, to me, only cosmetic. Cheers -- Gérard http://pagesperso-orange.fr/GRTux/ "J'ai décidé d'être heureux parce que c'est bon pour la santé. Voltaire " |
From: Jon S. B. <js...@ha...> - 2008-06-06 01:41:00
|
I don't have all of this conversation, but here are a few items: 1) I'll be glad to make changes in JSBSim as needed. This is the first I've read of the changes. Which of the posts here is the pertinent one? 2) Dave Culp (and others?) have actually been using the latest JSBSim in FlightGear for a while, now, for testing. I've compiled it in here at home, too, but haven't really used it much. I have access to the FlightGear CVS tree in the JSBSim directory. It's really my fault that the current JSBSim is not in FlightGear CVS, and I apologize for the foot-dragging. Jon |
From: Tim M. <ti...@re...> - 2008-06-06 05:37:52
|
On Thu, 5 Jun 2008 20:29:24 -0500 "Jon S. Berndt" <js...@ha...> wrote: > I don't have all of this conversation, but here are a few items: > > 1) I'll be glad to make changes in JSBSim as needed. This is the > first I've read of the changes. Which of the posts here is the > pertinent one? > I've sent my changes to jsbsim-devel. However, I'm not subscribed to that list and I haven't been able to check the archives to see if my message got through. Tim |
From: Tim M. <ti...@re...> - 2008-06-06 05:35:46
|
On Thu, 5 Jun 2008 23:11:03 +0200 Melchior FRANZ <mf...@ao...> wrote: > * Tim Moore -- Thursday 05 June 2008: > > I never got the memo that large parts of the tree were off limits. > > In the old days one didn't need memos for that. One had to be around > long enough before one even got CVS access. Enough time to learn the > rules. Not your fault, of course, that this has changed now. > > > > > I don't really see the point for fairly cosmetic changes. > > The point is: what you consider an improvement might not be seen as > such by the code *owner*. And the owner's wish usually trumps a > contributor's. > I understand, and I didn't really understand the situation wrt to JSBSim. > > > > On the other hand, why is JSBSim in our CVS at all if new versions > > are brought in in this way? > > What way would you prefer? Some projects are on other servers, and > CVS has no way to import them directly. They need to be copied in. > This hasn't been a problem in the past. You just have to know that > making changes in those copies is totally pointless. If we really have no capability or desire to make local changes to JSBSim (for example), then I'd prefer that we'd say "get JSBSim from the JSBSim CVS server" like we do with plib. At the very least it should have imported on a vendor branch into our CVS so that local changes could be easily maintained. Tim |
From: Melchior F. <mf...@ao...> - 2008-06-06 07:20:59
|
* Tim Moore -- Friday 06 June 2008: > [...] then I'd prefer that we'd say "get JSBSim from the > JSBSim CVS server" like we do with plib. At the very least it should > have imported on a vendor branch into our CVS so that local changes > could be easily maintained. Solution in search of a problem? We never had a problem with JSBSim being maintained outside -- just like simgear/nasal/, which is maintained in :pserver:cv...@pl...:/home/nasal-cvs). But maybe we should have a wiki page about things a new developer should know (taboos; the flightgear (non-)coding-style; "good behavior")? m. |
From: Frederic B. <fre...@fr...> - 2008-06-06 07:07:12
Attachments:
jsbsim_errors.txt.gz
|
Hi Tim, ----- "Tim Moore" <mo...@br...> a écrit : > On Thu, 5 Jun 2008 22:15:41 +0200 (CEST) > Frederic Bouvier <fre...@fr...> wrote: > > > > > ----- "Curtis Olson" <cur...@gm...> a écrit : > > > > > On Thu, Jun 5, 2008 at 10:22 AM, Melchior FRANZ wrote: > > > > > > > * gerard robin -- Thursday 05 June 2008: > > > > > Does this will be compatible with actual JSBSim development ? > > > > > > > > No, it will get overwritten with the next JSBSim update. There's > > > > a reason why commits to externally maintained parts of fgfs > > > > (nasal, jsbsim) used to be taboo [snip] > > > > > > > > The right thing would have been to ask the responsible > > > > maintainers, to have them make the changes in their > repositories, > > > > and then to forward port that. [snip] > > > > > > > > > Tim has already been made aware that changes to JSBsim need to be > > > submitted > > > upstream or they will be lost the next time we sync with their > > > code. I > > > assume he has made contact there so these changes (if important) > > > aren't lost > > > in the future. It's good to see a few others besides myself > > > watching to > > > catch things like this. > > > > These changes are very unfortunate. Like it or not, cin, cerr and > > cout are defined in <iostream> under MSVC. > > > > FG is no longer compilable for me :-((((( > > > > -Fred > > > I know that cin, cerr and cout are defined in <iostream>; they're > defined that way in every conforming C++ implementation. But they are > only used in a very few places and don't need to be sucked into every > file. Can you be more specific about the problems you are seeing? The issue is that a lot of JSBsim files have problems with cout or cerr not defined. Moreover, you can't include a statement like "using std::cerr;" if std::cerr is not already defined. The result of the compilation is attached to this message. -Fred -- Frédéric Bouvier http://my.fotolia.com/frfoto/ Photo gallery - album photo http://fgsd.sourceforge.net/ FlightGear Scenery Designer |
From: Melchior F. <mf...@ao...> - 2008-06-06 07:13:51
|
* Frederic Bouvier -- Friday 06 June 2008: > Moreover, you can't include a statement like "using std::cerr;" > if std::cerr is not already defined. Just for the record: I had to modify a few files in fg/JSBSim as well to make it compile. On Linux! This may be because I'm using a different build system. Maybe I need to add some -D symbol on the command line or something. Have yet to find out ... m. |
From: Tim M. <ti...@re...> - 2008-06-06 08:13:05
|
On Fri, 6 Jun 2008 09:13:49 +0200 Melchior FRANZ <mf...@ao...> wrote: > * Frederic Bouvier -- Friday 06 June 2008: > > Moreover, you can't include a statement like "using std::cerr;" > > if std::cerr is not already defined. > > Just for the record: I had to modify a few files in fg/JSBSim as > well to make it compile. On Linux! This may be because I'm using > a different build system. Maybe I need to add some -D symbol on > the command line or something. Have yet to find out ... > > m. Ok, obviously I'm interested in making it work on all our supported platforms. Let me know what changes you have made and I'll resubmit my patch to JSBSim. Tim |
From: Melchior F. <mf...@ao...> - 2008-06-06 09:11:24
|
* Tim Moore -- Friday 06 June 2008: > Let me know what changes you have made and I'll resubmit my > patch to JSBSim. The reason was: in the past the JSBSim in fgfs had to be compiled with -DFGFS, and there are "#ifdef FGFS" blocks in several of the JSBSim files. But these blocks are now obsolete and unused by fg, and with your patch they don't work anymore. I hadn't noticed that -DFGFS got dropped and still had it in my build system. Fixed, so nothing to do in CVS ... other than removing all the "#ifdef FGFS" in JSBSim. m. |
From: Frederic B. <fre...@fr...> - 2008-06-07 08:14:18
|
Hi Tim, Tim Moore a écrit : > On Fri, 6 Jun 2008 09:13:49 +0200 > Melchior FRANZ <mf...@ao...> wrote: > > >> * Frederic Bouvier -- Friday 06 June 2008: >> >>> Moreover, you can't include a statement like "using std::cerr;" >>> if std::cerr is not already defined. >>> >> Just for the record: I had to modify a few files in fg/JSBSim as >> well to make it compile. On Linux! This may be because I'm using >> a different build system. Maybe I need to add some -D symbol on >> the command line or something. Have yet to find out ... >> >> m. >> > > Ok, obviously I'm interested in making it work on all our supported > platforms. Let me know what changes you have made and I'll resubmit my > patch to JSBSim. > > I was able to compile JSBsim and FG today, except a small glitch with non portable code in new_gui.h I was able to fix using plib. Thanks, -Fred -- Frédéric Bouvier http://my.fotolia.com/frfoto/ Photo gallery http://fgsd.sourceforge.net/ FlightGear Scenery Designer |
From: Vivian M. <viv...@li...> - 2008-06-09 16:03:24
|
Fred wrote > Sent: 07 June 2008 09:14 > To: FlightGear developers discussions > Subject: Re: [Flightgear-devel] [Flightgear-cvslogs] CVS: > source/src/FDM/JSBSim/models/flight_control FGActuator.cpp, 1.2, 1.3 > FGFCSComponent.h, 1.3, 1.4 > > Hi Tim, > > Tim Moore a écrit : > > On Fri, 6 Jun 2008 09:13:49 +0200 > > Melchior FRANZ <mf...@ao...> wrote: > > > > > >> * Frederic Bouvier -- Friday 06 June 2008: > >> > >>> Moreover, you can't include a statement like "using std::cerr;" > >>> if std::cerr is not already defined. > >>> > >> Just for the record: I had to modify a few files in fg/JSBSim as > >> well to make it compile. On Linux! This may be because I'm using > >> a different build system. Maybe I need to add some -D symbol on > >> the command line or something. Have yet to find out ... > >> > >> m. > >> > > > > Ok, obviously I'm interested in making it work on all our supported > > platforms. Let me know what changes you have made and I'll resubmit my > > patch to JSBSim. > > > > > > I was able to compile JSBsim and FG today, except a small glitch with > non portable code in new_gui.h I was able to fix using plib. > > Thanks, > > -Fred Just hit that one - I hope it will be in fixed in cvs soon. Vivian |
From: Maik J. <mj...@gm...> - 2008-06-09 21:01:10
|
Hi Fred, Frederic Bouvier schrieb am 07.06.2008 10:14: > I was able to compile JSBsim and FG today, except a small glitch with > non portable code in new_gui.h I was able to fix using plib. > > Thank you! > Thanks, > > -Fred > > > Maik |
From: Anders G. <and...@gi...> - 2008-06-06 09:11:17
|
On Thu, 5 Jun 2008, Jon S. Berndt wrote: > 2) Dave Culp (and others?) have actually been using the latest JSBSim in > FlightGear for a while, now, for testing. I've compiled it in here at home, > too, but haven't really used it much. I have access to the FlightGear CVS > tree in the JSBSim directory. It's really my fault that the current JSBSim > is not in FlightGear CVS, and I apologize for the foot-dragging. Hi, I'm (one of?) the others that keep testing JSBSim/CVS in FlightGear/CVS. I try to keep an up to date patch for FlightGear/CVS here: http://www.gidenstam.org/FlightGear/Airships/patches/ I think it would be good if we could synch the JSBSim in FlightGear with JSBSim/CVS more often. Cheers, Anders -- --------------------------------------------------------------------------- Anders Gidenstam WWW: http://www.gidenstam.org/FlightGear/ |
From: gerard r. <gh...@gm...> - 2008-06-07 16:39:38
|
On ven 6 juin 2008, Anders Gidenstam wrote: > On Thu, 5 Jun 2008, Jon S. Berndt wrote: > > 2) Dave Culp (and others?) have actually been using the latest JSBSim in > > FlightGear for a while, now, for testing. I've compiled it in here at > > home, too, but haven't really used it much. I have access to the > > FlightGear CVS tree in the JSBSim directory. It's really my fault that > > the current JSBSim is not in FlightGear CVS, and I apologize for the > > foot-dragging. > > Hi, > > I'm (one of?) the others that keep testing JSBSim/CVS in FlightGear/CVS. I > try to keep an up to date patch for FlightGear/CVS here: > > http://www.gidenstam.org/FlightGear/Airships/patches/ > > I think it would be good if we could synch the JSBSim in FlightGear > with JSBSim/CVS more often. > > > Cheers, > > Anders Hello Anders, Nice, your is better than mine which is a bad 'DIY' more or less (rather less :) ) up to date. I will try it . Cheers -- Gérard http://pagesperso-orange.fr/GRTux/ "J'ai décidé d'être heureux parce que c'est bon pour la santé. Voltaire " |
From: Melchior F. <mf...@ao...> - 2008-06-05 15:22:58
|
* gerard robin -- Thursday 05 June 2008: > Does this will be compatible with actual JSBSim development ? No, it will get overwritten with the next JSBSim update. There's a reason why commits to externally maintained parts of fgfs (nasal, jsbsim) used to be taboo, just like commits to parts which are strictly maintained by a single person or small group (YASim). (UIUC may no longer belong to either group, as it seems to be unmaintained.) The right thing would have been to ask the responsible maintainers, to have them make the changes in their repositories, and then to forward port that. But then again, times change, and maybe all that is no longer true ... m. |
From: Curtis O. <cur...@gm...> - 2008-06-05 15:51:06
|
On Thu, Jun 5, 2008 at 10:22 AM, Melchior FRANZ wrote: > * gerard robin -- Thursday 05 June 2008: > > Does this will be compatible with actual JSBSim development ? > > No, it will get overwritten with the next JSBSim update. There's > a reason why commits to externally maintained parts of fgfs (nasal, > jsbsim) used to be taboo [snip] > > The right thing would have been to ask the responsible maintainers, > to have them make the changes in their repositories, and then to > forward port that. [snip] Tim has already been made aware that changes to JSBsim need to be submitted upstream or they will be lost the next time we sync with their code. I assume he has made contact there so these changes (if important) aren't lost in the future. It's good to see a few others besides myself watching to catch things like this. Best regards, Curt. -- Curtis Olson: http://baron.flightgear.org/~curt/ |
From: Frederic B. <fre...@fr...> - 2008-06-05 20:15:37
|
----- "Curtis Olson" <cur...@gm...> a écrit : > On Thu, Jun 5, 2008 at 10:22 AM, Melchior FRANZ wrote: > > > * gerard robin -- Thursday 05 June 2008: > > > Does this will be compatible with actual JSBSim development ? > > > > No, it will get overwritten with the next JSBSim update. There's > > a reason why commits to externally maintained parts of fgfs (nasal, > > jsbsim) used to be taboo [snip] > > > > The right thing would have been to ask the responsible maintainers, > > to have them make the changes in their repositories, and then to > > forward port that. [snip] > > > Tim has already been made aware that changes to JSBsim need to be > submitted > upstream or they will be lost the next time we sync with their code. > I > assume he has made contact there so these changes (if important) > aren't lost > in the future. It's good to see a few others besides myself watching > to > catch things like this. These changes are very unfortunate. Like it or not, cin, cerr and cout are defined in <iostream> under MSVC. FG is no longer compilable for me :-((((( -Fred -- Frédéric Bouvier http://my.fotolia.com/frfoto/ Photo gallery - album photo http://fgsd.sourceforge.net/ FlightGear Scenery Designer |
From: Maik J. <mj...@gm...> - 2008-06-05 20:40:56
|
Frederic Bouvier schrieb am 05.06.2008 22:15: > > These changes are very unfortunate. Like it or not, cin, cerr and cout are defined in <iostream> under MSVC. > > FG is no longer compilable for me :-((((( > > -Fred > > Hi Fred, don't know what is different here, but yesterday evening I compiled fresh cvs osg-fg on MSVC-express without problem (based in Olaf Flebbes project files). I have the problem, that some parts of the static scenery isn't found (alcatraz, stadium near KSFO and many others, but not all). The fg-root path is added twice, so I changed my starting directory, that fg-root can be added twice (fg-root=../../fg-cvs/data). I don't know, when this problem started, my last build was rather old... Maik |
From: Frederic B. <fre...@fr...> - 2008-06-06 07:12:01
|
Hi Maik, ----- "Maik Justus" a écrit : > Frederic Bouvier schrieb am 05.06.2008 22:15: > > > > These changes are very unfortunate. Like it or not, cin, cerr and > cout are defined in <iostream> under MSVC. > > > > FG is no longer compilable for me :-((((( > > > > -Fred > > > > > > Hi Fred, > > don't know what is different here, but yesterday evening I compiled > fresh cvs osg-fg on MSVC-express without problem (based in Olaf > Flebbes project files). I build FG with MSVC 7.1 > I have the problem, that some parts of the static scenery isn't found > > (alcatraz, stadium near KSFO and many others, but not all). The fg-root > path is added twice, so I changed my starting directory, that fg-root > can be added twice (fg-root=../../fg-cvs/data). I don't know, when this > problem started, my last build was rather old... Recently, I fixed a problem with SGPagedLOD that prevented some model to be loaded. In fact, the DatabasePager was exiting prematurely, before loading all models. -Fred -- Frédéric Bouvier http://my.fotolia.com/frfoto/ Photo gallery - album photo http://fgsd.sourceforge.net/ FlightGear Scenery Designer |
From: Tim M. <mo...@br...> - 2008-06-05 20:27:30
|
On Thu, 5 Jun 2008 22:15:41 +0200 (CEST) Frederic Bouvier <fre...@fr...> wrote: > > ----- "Curtis Olson" <cur...@gm...> a écrit : > > > On Thu, Jun 5, 2008 at 10:22 AM, Melchior FRANZ wrote: > > > > > * gerard robin -- Thursday 05 June 2008: > > > > Does this will be compatible with actual JSBSim development ? > > > > > > No, it will get overwritten with the next JSBSim update. There's > > > a reason why commits to externally maintained parts of fgfs > > > (nasal, jsbsim) used to be taboo [snip] > > > > > > The right thing would have been to ask the responsible > > > maintainers, to have them make the changes in their repositories, > > > and then to forward port that. [snip] > > > > > > Tim has already been made aware that changes to JSBsim need to be > > submitted > > upstream or they will be lost the next time we sync with their > > code. I > > assume he has made contact there so these changes (if important) > > aren't lost > > in the future. It's good to see a few others besides myself > > watching to > > catch things like this. > > These changes are very unfortunate. Like it or not, cin, cerr and > cout are defined in <iostream> under MSVC. > > FG is no longer compilable for me :-((((( > > -Fred > I know that cin, cerr and cout are defined in <iostream>; they're defined that way in every conforming C++ implementation. But they are only used in a very few places and don't need to be sucked into every file. Can you be more specific about the problems you are seeing? Tim |
From: Vivian M. <viv...@li...> - 2008-06-06 11:27:35
|
Frederic Bouvier > > > ----- "Curtis Olson" <cur...@gm...> a écrit : > > > On Thu, Jun 5, 2008 at 10:22 AM, Melchior FRANZ wrote: > > > > > * gerard robin -- Thursday 05 June 2008: > > > > Does this will be compatible with actual JSBSim development ? > > > > > > No, it will get overwritten with the next JSBSim update. There's > > > a reason why commits to externally maintained parts of fgfs (nasal, > > > jsbsim) used to be taboo [snip] > > > > > > The right thing would have been to ask the responsible maintainers, > > > to have them make the changes in their repositories, and then to > > > forward port that. [snip] > > > > > > Tim has already been made aware that changes to JSBsim need to be > > submitted > > upstream or they will be lost the next time we sync with their code. > > I > > assume he has made contact there so these changes (if important) > > aren't lost > > in the future. It's good to see a few others besides myself watching > > to > > catch things like this. > > These changes are very unfortunate. Like it or not, cin, cerr and cout are > defined in <iostream> under MSVC. > > FG is no longer compilable for me :-((((( > I haven't been able to use FG for weeks now. I've been incommunicado for a while now due to pressure of work, and more recently a complete system failure here. Did we ever sort out the problems with throwing exceptions etc.? Vivian |
From: Jon S. B. <js...@ha...> - 2008-06-06 13:37:24
|
Curt wrote: > Tim has already been made aware that changes to JSBsim > need to be submitted upstream or they will be lost the > next time we sync with their code. I assume he has made > contact there so these changes (if important) aren't lost > in the future. It's good to see a few others besides > myself watching to catch things like this. I'm trying to figure out what's being resolved in this thread. Are we saying that whacko constructs like this are no longer needed: #ifdef FGFS # include <simgear/compiler.h> # include STL_STRING # include STL_IOSTREAM # include STL_FSTREAM SG_USING_STD(cout); SG_USING_STD(endl); #else # include <string> # if defined(sgi) && !defined(__GNUC__) && (_COMPILER_VERSION < 740) # include <iostream.h> # include <fstream.h> # else # include <iostream> # include <fstream> using std::cout; using std::endl; # endif #endif ... and are instead replaced with this? #include <string> #include <iostream> #include <fstream> using std::cout; using std::endl; using std::string; Jon |