From: <fli...@go...> - 2015-02-15 14:59:29
|
Status: New Owner: ---- Labels: Aircraft-p51d JSBSIM New issue 1673 by gijsrooy: P-51D wants 'system' instead of 'autopilot' https://code.google.com/p/flightgear-bugs/issues/detail?id=1673 What steps will reproduce the problem? 1. Launch the P-51D What is the expected output? What do you see instead? FlightGear fails on startup with: In file Aircraft/p51d/p51d-jsbsim.xml: line 579 Read model 'autopilot' while expecting model 'system' What FlightGear version (or GIT date)? Today's Git If I change the 'autopilot' tags in the System files (under Aircraft/p51d/Systems) to 'system', it loads fine. I'm not sure if we should push that as a fix though, as it's apparently been working fine for over four years! Any ideas? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings |
From: <fli...@go...> - 2015-02-16 19:11:32
|
Updates: Status: WontFix Comment #1 on issue 1673 by bcoco...@gmail.com: P-51D wants 'system' instead of 'autopilot' https://code.google.com/p/flightgear-bugs/issues/detail?id=1673 Yes there is a modification in JSBSim which results in the FDM being more strict when using the 'file=' parameter in a tag. Now JSBSim verifies that the head tag in the file is the same than the tag that called the file. Say the user requests to include a file "xyz.xml" containing an <aerodynamics> section via a <ground_reaction file="xyz"> tag, JSBSim now issues an error message stating that it read an 'aerodynamics' section while it was expecting a 'ground_reaction' section. Previously when the tags were not matching, JSBSim was either silently ignoring the included file or it was issuing error messages that were difficult to link to the initial error (tried to include an incorrect file). This new check has been added to help the aircraft developer to debug his/her model by issuing an (hopefully) explicit message. The case of the P-51D is really a corner case because 'autopilot' and 'systems' are basically the same thing in JSBSim that is the reason why it worked for 4 years even though the tags were mismatching. However it is never too late to get some good habits and change the P-51D model to have the tags matching. It does not seem much of a big deal, does it ? :-) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings |
From: <fli...@go...> - 2015-02-17 20:05:05
|
Comment #2 on issue 1673 by gijsrooy: P-51D wants 'system' instead of 'autopilot' https://code.google.com/p/flightgear-bugs/issues/detail?id=1673 Ah, thanks for the explanation! I've just pushed a fix to fgaddon. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings |
From: <fli...@go...> - 2015-03-15 13:18:08
|
Comment #3 on issue 1673 by gijsrooy: P-51D wants 'system' instead of 'autopilot' https://code.google.com/p/flightgear-bugs/issues/detail?id=1673 Bertrand, it seems to be broken again with current Git. Now it's expecting 'autopilot' instead of 'system'. Did someone revert the JSBSim change? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings |
From: <fli...@go...> - 2015-03-16 22:08:37
|
Comment #4 on issue 1673 by bcoco...@gmail.com: P-51D wants 'system' instead of 'autopilot' https://code.google.com/p/flightgear-bugs/issues/detail?id=1673 [Tested p51d rev 428] Line 579 of p51d-jsbsim.xml the tag <autopilot file="Systems/autothrottle"/> is calling the file Systems/autothrottle.xml which contains <system> (should be <autopilot>) AFAICS FlightGear source code has not been changed and JSBSim is rightfully reporting an error : the p51d XML files are inconsistent. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings |