From: Nando D. <na...@de...> - 2005-09-22 08:12:23
|
Michael, M> First let me propose a small refactoring: Right now MetadataCollection, M> Relation and Procedure all inherit from MetadataItem. Why don't we M> create a new class MetadataItemWithChildren, which will be base class M> for those three. This would move some of the common code out of M> MetadataCollection, making the instantiated templated code smaller. It M> would also be the one place to override lockSubject() and M> unlockSubject(), which I had to do in all three classes otherwise. Or M> is there anything speaking against this? again, just one word: Composite. ;-) Have a look at it for insights, nomenclature, etc. M> The more difficult thing is the management of the update lock counter M> for children. There is code in MetadataCollection to create new M> children, but they are always created with the lock counter set to 0, M> even if the parent has a higher lock count. I'm not sure I get it. Is your problem due to the necessity of locking/unlocking single collection items? OTTOMH I'd say that a collection item locks and unlocks its containing collection, and hasn't got a lockcount of its own, but I am missing some details for sure. Ciao -- Nando Dessena http://www.flamerobin.org |