1. Increase inline function growth limit by adding –param large-function-growth=10000 to CFLAGS.
2. In file replaygain_analysis.c, check if __MINGW32__ is defined, and if so then don’t execute “#pragma warning ( disable : 4305 )”. This is done in 2 places in file.
3. In file utf8.c, cast GetLastError() to int in all places it occurs in fprintf statement.
1 has performance implications; we don't want to try to outsmart the compiler
2,3 checked in.
thanks!
Many thanks Josh! Concerning 1, would the performance be lower with it? If so then I will remove it from my build and accept the warnings. Perhaps the warnings could be mensioned in readme file. Thanks again.
it might be lower; the warnings are annoying though. I plan on doing another round of profiling to see if explicitly inlining so much still yields faster code.