#32 Fix warnings on MinGW

closed-fixed
None
7
2009-01-03
2008-10-30
Mikael
No

1. Increase inline function growth limit by adding –param large-function-growth=10000 to CFLAGS.

2. In file replaygain_analysis.c, check if __MINGW32__ is defined, and if so then don’t execute “#pragma warning ( disable : 4305 )”. This is done in 2 places in file.

3. In file utf8.c, cast GetLastError() to int in all places it occurs in fprintf statement.

Discussion

  • Josh Coalson

    Josh Coalson - 2009-01-02
    • priority: 5 --> 7
    • assigned_to: nobody --> jcoalson
    • status: open --> open-accepted
     
  • Josh Coalson

    Josh Coalson - 2009-01-03

    1 has performance implications; we don't want to try to outsmart the compiler

    2,3 checked in.

    thanks!

     
  • Josh Coalson

    Josh Coalson - 2009-01-03
    • status: open-accepted --> closed-fixed
     
  • Mikael

    Mikael - 2009-01-10

    Many thanks Josh! Concerning 1, would the performance be lower with it? If so then I will remove it from my build and accept the warnings. Perhaps the warnings could be mensioned in readme file. Thanks again.

     
  • Josh Coalson

    Josh Coalson - 2009-01-12

    it might be lower; the warnings are annoying though. I plan on doing another round of profiling to see if explicitly inlining so much still yields faster code.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks