#3856 New package for 'hping3'

[KingNothing]

Hi everybody,
this is a new package for hping3, please check it and commit it.
There are no known os restirctions.
Section: net
Successfully build with with -m --build-as-nobody.

dpkg -L hping3 output:
/.
/sw
/sw/sbin
/sw/sbin/hping3
/sw/share
/sw/share/man
/sw/share/man/man8
/sw/share/man/man8/hping2.8
/sw/share/man/man8/hping3.8
/sw/sbin/hping
/sw/sbin/hping2

[KingNothing]

package info file

[KingNothing]

patch file

[Hanspeter Niederstrasser]

Configure seems to only look in /usr for libraries.

The final linker command looks like this:

gcc -o hping3 -O2 -Wall -I/sw32/include -DUSE_TCL -g main.o getifname.o getlhs.o parseoptions.o datafiller.o datahandler.o gethostname.o binding.o getusec.o opensockraw.o logicmp.o waitpacket.o resolve.o sendip.o sendicmp.o sendudp.o sendtcp.o cksum.o statistics.o usage.o version.o antigetopt.o sockopt.o listen.o sendhcmp.o memstr.o rtt.o relid.o sendip_handler.o libpcap_stuff.o memlockall.o memunlockall.o memlock.o memunlock.o ip_opt_build.o display_ipopt.o sendrawip.o signal.o send.o strlcpy.o arsglue.o random.o scan.o hstring.o script.o interface.o adbuf.o hex.o apdutils.o sbignum.o sbignum-tables.o ars.o apd.o split.o rapd.o -L/usr/local/lib -lpcap -ltcl -lm -lpthread

And this causes hping3 to link to system-libpcap and the Tcl framework vs using Fink's libraries (preferred). Either -L%p/lib must be added as a linker flag (LDFLAGS possibly), or -L/usr/local/lib must be patched to -L%p/lib. Since tcl will then be brought in, (Build)dependencies on tcltk(-shlibs) must be added to the package.

Also, /usr/bin/tclsh8.4 is detected. The build should be patched to find Fink's in %p (note that x86_64 builds use tclsh8.5, so don't hardcode to one version)

Finally, on 10.6/x86_64, the build errors with this:

In file included from ars.h:20,
from apd.c:19:
bytesex.h:22:3: error: #error can not find the byte order for this architecture, fix bytesex.h
In file included from apd.c:19:
ars.h:190:2: error: #error "Please, edit Makefile and add -DBYTE_ORDER_(BIG|LITTLE)_ENDIAN"

It looks like bytesex.h doesn't realize that x86_64 build are also little endian. Please fix this also, or mark the pkg as Architecture: i386, powerpc

[Paul Beard]

I have updated hping3.info and hping3.patch with the feedback above.

[Alexander Hansen]

The linkages look OK for me.

Why is this tagged as Distribution: 10.9? The tcltk version? If that's the case, how about making this one hping3-10.9.info and bumping the Revision to 101 or something, and then have an hping3.info with Distribution: 10.7,10.8 for those OS X versions at revision 1 and targeting tcltk 8.5.

We generally like packages to include their documentation (in this case the docs/ and RFCs directories (without the CVS directories) along with the files like AUTHORS, BUGS, COPYING, etc.--I usually don't include INSTALL since end-users have already installed the package). For packages with a GPL license it is mandatory to include a file which contains the text of the GPL--COPYING is the usual choice.

[Paul Beard]

The tcltk version and the distribution were what I happened to have on my computer. I don't know how to test with other versions and distributions. It appears that hping3 should work with tcltk (>= 8.0). I have added the docs, updated the tcltk version, and removed the version and distribution limitations that I couldn't justify.

[Alexander Hansen]

Ah, OK. Testing other distributions is only possible if you've got the proper OS X version for them. I wanted to verify that there was no other fundamental reason that the package wouldn't work on 10.8 or 10.7.