Re: [FFADO-devel] [patch][BeBoB/Presonus] Firebox support improvement

[Jonathan W. <jw...@ju...>]

Hi Takashi

On Wed, Oct 30, 2013 at 12:05:11AM +0900, Takashi Sakamoto wrote:
> This series of patche is for improvement of  PreSonus Firebox support.
> :
> For your information, as long as comparing subunit information of
> FIREBOX/FIREPOD in developers page, there is huge differences between
> these two devices. This series of patch adds FireboxDevice class but
> this class cannot be reused for FIREPOD.
> http://subversion.ffado.org/wiki/AvcModels

I assume that in your opinion it's not feasible to attempt to write a
Presonus driver which uses the subunit information from the device to adapt
as needed?  Of course something like this could always be written, but if
the code ends up being horrendously complex there's little advantage in
using it.

I have briefly looked through the code and I can't see anything out of
place.  If the resulting code compiles and works for you with the Firebox
device you have access to then I have no objection to it being merged.

Thank you for your continued efforts in improving our support for these
devices.

Regards
  jonathan