Re: [FFADO-devel] Patch: prefer installed over system ffado python modules

[Nils P. <ni...@ti...>]

Hi Jonathan,

On Wed, 2012-04-18 at 19:39 +0930, Jonathan Woithe wrote:
> > I've recently stumbled over using libffado and ffado-mixer which I built
> > from source, but with the packaged (old) ffado python modules. While I
> > could mess with PYTHONPATH, I've found that the python programs already
> > add the directory into which python modules are installed to sys.path,
> > just at the end -- and because the old modules are installed into the
> > same prefix as the python binary, they get preferred.
> 
> So does this mean that the "old" ffado python modules - the ones installed
> by the distribution's ffado package - are installed into the system python
> directories instead of a separate directory (the latter being the default
> behaviour, which is why the old weren't overwritten by the new after you
> installed your locally compiled version)?  For example, on my system the
> ffado python modules are in
> 
>   /usr/local/lib/python2.6/site-packages/ffado
> 
> which is clearly different from the python binary (/usr/bin/python), the
> ffado programs themselves (/usr/local/bin/) or the system python module path
> (/usr/lib/python2.6/).
>
> > I've attached a patch which prepends $PYPKGDIR to sys.path instead of
> > appending it, would be nice if someone committed this to the upstream
> > repository.
> 
> I'm not opposed to committing this and will do so later when I've got more
> time, but at the same time it seems that maybe the root cause of this
> particular issue is the installation of the ffado python modules into a
> place where they possibly shouldn't be going by the distributor's package. 
> Hense my clarification request above.  If there is a faulty distributor
> package out there we should probably get that fixed too.

It seems that I've confused you already :-).

Recapitulating, the "old" ffado-mixer stuff is from official
distribution packages and therefore rightfully in /usr, not /usr/local.
I'd rather not uninstall it because that would break a lot of
dependencies. The ffado packages I've built from source are in
$HOME/opt/... and work fine when setting LD_LIBRARY_PATH accordingly
(there's no way around this btw if I want to use packaged jackd with
SVN/git ffado). Python fortunately lets us fix sys.path in programs,
therefore my patch -- I'd rather have it done right by default and not
rely on environment if I can avoid it.

> Given the @redhat email address mentioned in the patch, I presume the
> distribution we're talking about is Redhat and/or Fedora.

The distribution I'm using is Fedora, currently 16 on the affected
machine.

HTH,
Nils
-- 
Nils Philippsen / Wilhelmstraße 22 / D-71229 Leonberg 
ni...@ti... / ni...@re...
PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011
Ever noticed that common sense isn't really all that common?