From: Arturo 'B. B. <bu...@bu...> - 2009-08-28 23:19:48
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Cyril Jaquier wrote: > Hi Arturo, Call me Buanzo :) > Mmmhhh... Trunk has some fundamental changes compared with 0.8. I think > we should improve/fix 0.8 which is the current "stable" version. I don't > think there should be any problems to work in the 0.8 branch but I may > have missed something!? Sure. Feel free to roll-back my commits to trunk (my "banip" patch applied 100% cleanly to it, anyway). I'll move the stuff to branch 0.8 if you prefer, but let me know if I misunderstood you. > Good :) Could you split the commits in the feature? 1 commit = 1 feature > if possible. It is easier to review/follow changes, revert and export > patches. Thanks. Sure, no problem. Do you have a document stating your 'best practices' for fail2ban developers? By the way, I'm half-way to solving the "Unexpected communications problem" with python 2.6. Apparently, there are some substantial differences in asynchat/asyncore in Python 2.6 and 3.0. I'm getting more familiar with the usage of your Requesthandler(asynchat.async_chat) class before touching anything. The problem itself appeared when I added some debugging code to the handle_error() method, and I got this in the log: 2009-08-29 00:12:28,420 fail2ban.jail : INFO Jail 'named-refused-tcp' started 2009-08-29 00:12:28,438 fail2ban.server : ERROR Unexpected communication error 2009-08-29 00:12:28,444 fail2ban.server : ERROR E1 = error 2009-08-29 00:12:28,454 fail2ban.server : ERROR E2 = [Errno 9] Bad file descriptor The "bad file descriptor" message plus "asynchat" in google are sending me in the right direction. If someone beats me to fixing it, be my guest :) - -- Arturo "Buanzo" Busleiman / Arturo Busleiman @ 4:900/107 Independent Linux and Security Consultant - SANS - OISSG - OWASP http://www.buanzo.com.ar/pro/eng.html Mailing List Archives at http://archiver.mailfighter.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEAREKAAYFAkqYZgUACgkQAlpOsGhXcE1CMACfcr+P/vKfRCyG1XENwDLbLQU5 Cg0An1LMfArCAjClb9fG7eF6qmIIVY+o =JXMx -----END PGP SIGNATURE----- |