Re: [Exist-development] servlet's refactoring

[Adam R. <ad...@ex...>]

I am concerned by the lack of testing that is being carried out.

trunk should always be stable, buildable and useable, this also means
that all tests in the test suite should pass. I am also not happy when
I see new code being added without new tests. This leads to all sorts
of worries and issues such as unmaintainable/ununderstandable code
should a commiter leave. The tests should reveal business logic
intention and bounds for execution.

Branches are fine for writting code and testing yourself, but who else
has tested your branch? I would really like to see major changes,
tested by more than just one person. This could perhaps be as simple
as announcing the feature and request for testing on the mailing list
and producing a test release of some sort for those interested users
to test. Once their feedback is positive these changes could be merged
into trunk.


2010/1/25 Dmitriy Shabanov <sha...@gm...>:
> On Mon, Jan 25, 2010 at 3:49 AM, Adam Retter <ad...@ex...> wrote:
>>
>> On 24 January 2010 15:27, Dmitriy Shabanov <sha...@gm...> wrote:
>> > Hello,
>> >
>> > I did rewrite servlets to integrate servlet's native authentication
>> > mechanism
>> > (http://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html -
>> > SRV.12.5 Authentication)
>> >
>> > I would like to switch trunk to "red". Waiting for "green" response ...
>>
>> What does this mean?
>>
> "Red" trunk mean no commits untill another person confirm that trunk have no
> issue (new as minimum)
>
> --
> Dmitriy Shabanov
>



-- 
Adam Retter

eXist Developer
{ United Kingdom }
ad...@ex...
irc://irc.freenode.net/existdb